Repository navigation
[Automated] Draft docs (agentgateway): proxy: better direct response handling - #1505
Merged
Merged
Conversation
…handling Drafts-Commit: a730fba Signed-off-by: GitHub Action <action@github.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Art Berger <art.berger@solo.io>
artberger
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
agentgateway/agentgateway#4250 — proxy: better direct response handling
Docs versions:
standalone/main,kubernetes/mainNo code-path rule covers 9 touched file(s). The planner could route these only by identifier search, so the candidate pages may miss what they changed, including in the other mode:
Cargo.tomlcrates/agentgateway/src/http/mod.rscrates/agentgateway/src/proxy/gateway.rscrates/agentgateway/src/proxy/httpproxy.rscrates/agentgateway/src/proxy/mod.rscrates/http/src/lib.rsWhat changes for users: Direct responses now keep the reason from the component that produced them. MCP backend external authorization denials return the authorization service's status and body instead of
500; ExtProc response-phaseImmediateResponsereplies are returned to clients; buffer-limit and CSRF rejections include client-safe response bodies.What the docs now say: The standalone CSRF page now shows the
csrf validation failedresponse body. The standalone body buffering page now names the413and502statuses and therequest body too largeandupstream response too largeresponse bodies for fail-closed buffer-limit rejections.How
agentgateway-4250was draftedPlan, and what changed it
DirectResponsereason; the stale actionable prose was on the standalone CSRF and buffer pages.Why a documentation change is necessary
The pull request changes observable responses, not configuration shape. The body says failed CSRF checks now return
csrf validation failed, request buffer failures returnrequest body too large, and response buffer failures returnupstream response too large. The standalone CSRF and body buffering pages documented the old response text or did not name these client-visible bodies, so readers could not predict the new results.How to verify this change
mainbuild with a route-levelcsrfpolicy and send a cross-site state-changing request.HTTP 403with the response bodycsrf validation failed, and the request log records an authorization reason with the CSRF error.policies.buffer.request.maxBytesandpolicies.buffer.response.maxByteswithfailureMode: failClosed, then send request and response bodies larger than those limits. The request-body case returnsHTTP 413withrequest body too large; the response-body case returnsHTTP 502withupstream response too largeif response headers were not already sent.Files in this pull request
content/docs/standalone/main/documentation/configuration/security/csrf.mdcontent/docs/standalone/main/documentation/configuration/traffic-management/buffer.mdHow the pages were chosen (triage report)
Draft a documentation change
agentgateway/agentgateway#4250 — proxy: better direct response handling
agentgateway/websiteCargo.tomlcrates/agentgateway/src/http/mod.rscrates/agentgateway/src/proxy/gateway.rscrates/agentgateway/src/proxy/httpproxy.rscrates/agentgateway/src/proxy/mod.rscrates/http/src/lib.rsRelease notes. This change's release note is not in this pull request. agentgateway/website keeps the PR tracker's notes in one pull request, from a
pr-tracker-draft-rolling-notes-*branch, and this run adds it there.Draft branch:
pr-tracker-draft-agentgateway-4250