Skip to content

Fix stale text found in the round 7 pr-tracker triage - #1552

Closed
artberger wants to merge 3 commits into
mainfrom
adb-pr-tracker-r7-followups
Closed

artberger wants to merge 3 commits into
mainfrom
adb-pr-tracker-r7-followups

Conversation

@artberger

@artberger artberger commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

miscellaneous updates while reviewing a bunch of PRs

AI-generated summary

Summary

Fixes stale text that the round 7 pr-tracker triage found outside the bot PRs. No file here is edited by an open pr-tracker PR. #1488 and #1507 are already merged.

Fixes

1. AgentgatewayModel status warning (Kubernetes latest)

File: content/docs/kubernetes/latest/documentation/llm/models/serve.md

The page said that AgentgatewayModel does not yet report status. That is false since v1.7.0. The warning is gone. The troubleshooting steps now include the same status.parents check that main has.

Source:

  • controller/pkg/agentgateway/translator/testdata/models/llm-listener.yaml at tag v1.7.0, lines 141-160. It shows status.parents with Accepted: True and ResolvedRefs: True on an AgentgatewayModel.
  • The NotAllowedByListeners message example is not copied to latest, because its test fixture not-allowedkind.yaml is main-only.

2. CSRF client-safe error body (shared asset)

File: assets/agw-docs/pages/security/csrf.md

On main, the client body for a CSRF rejection is csrf validation failed (lowercase). Older versions return CSRF validation failed. The sequence diagram and the example output are each gated as a whole pair. The exclude-if and include-if lists use 1.0.x to 1.7.x plus 2.2.x, as the lists for pages/ assets do.

Source (upstream agentgateway/agentgateway):

  • crates/agentgateway/src/http/csrf.rs on main. Csrf::apply returns ProxyError::CsrfValidationFailed.
  • crates/agentgateway/src/proxy/mod.rs:482 on main. external_message() maps CsrfValidationFailed to "csrf validation failed".
  • At v1.7.0, csrf.rs built a direct 403 response with the body CSRF validation failed. Commit df3e4b43 (#4250, Nov 2) is not in v1.7.0.

I did not document AGENTGATEWAY_UNSAFE_EXPOSE_ERROR_DETAILS. It is an unsafe convenience setting.

3. backend row of the policy precedence table (Kubernetes main)

File: content/docs/kubernetes/main/documentation/about/policies/target-merge.md

Two defects in the backend section:

  1. The precedence order was wrong. Route and Route rule targets override Service and Backend targets. The order is now Gateway < Listener < Service or Backend (targetRef) < Sub-backend (targetRef with sectionName) < Route (targetRef) < Route rule (targetRef) < Backend (inline) < Route backend ref (inline). A sentence with an example explains the Route-over-Backend case.
  2. The table listed ListenerSet as a valid backend target. The API server accepts it, but the data plane never reads it for the backend phase. ListenerSet is removed from the row. A note explains that such a policy reports Attached and has no effect.

Source:

  • crates/agentgateway/src/store/binds.rs, internal_backend_policies, around lines 1335-1375 on main. Policies are first-writer-wins in this order: backendRef inline, Backend inline, route rule, route, sub-backend, backend, listener, gateway. There is no ListenerSet lookup. The same chain is in v1.7.0.
  • crates/agentgateway/src/proxy/httpproxy.rs, get_backend_policies. This is the source of the inline order.

Runtime test on a Kubernetes cluster with Enterprise agentgateway 2026.11.0. It used a temporary namespace that was deleted afterwards. A go-httpbin app, an HTTPRoute, and AgentgatewayPolicy resources with backend.transformation.request.set of x-prec. The request header that httpbin echoed showed the winner:

Policies present Header value
Gateway, Service service
Gateway, Service, Route route
Gateway, AgentgatewayBackend, Route route
Gateway, AgentgatewayBackend backend
Gateway, AgentgatewayBackend, Route, Route rule route-rule
ListenerSet only (backend section), route on a ListenerSet listener header absent, policy reports Attached=True
Same, plus a ListenerSet traffic policy traffic header applied, backend header still absent
Same, plus a Gateway backend policy gateway

Not tested at runtime: sub-backend against Route, and inline against attached policies. Those come from the code and the backend_policy_merging_precedence unit test.

Not changed

  • content/docs/kubernetes/latest, 1.5.x, and 1.6.x carry the same wrong backend precedence row. The chain is identical in v1.7.0.
  • content/docs/kubernetes/1.4.x, 1.5.x, and 1.6.x llm/models/serve.md still have the "does not yet report status" warning. I did not check when status reporting landed.
  • The standalone CSRF page (content/docs/standalone/*/documentation/configuration/security/csrf.md) has its own inline copy of CSRF validation failed. [Automated] Draft docs (agentgateway): proxy: better direct response handling #1505 edits that file, so I left it.

Verification

  • Built the site locally with Hugo. The CSRF page shows the lowercase text on main and the capitalized text on latest. The latest serve page has the new status step and no old warning. The target-merge page has the new row and note. No raw shortcodes leak.
  • The Cloudflare preview was not checked.
  • The commits are unsigned. They carry a DCO sign-off.

🤖 Generated with Claude Code

artberger and others added 3 commits November 16, 2026 20:29
AgentgatewayModel has reported status.parents since v1.7.0. Replace the
warning with the status check that main already has.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Art Berger <art.berger@solo.io>
On main, the client sees 'csrf validation failed' (lowercase). Older
versions keep 'CSRF validation failed'. Gate the diagram and the example
output as pairs.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Art Berger <art.berger@solo.io>
Route and Route rule targets override Service and Backend targets for
the backend section. ListenerSet targets have no effect on the backend
phase.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Art Berger <art.berger@solo.io>
@artberger
artberger marked this pull request as ready for review November 17, 2026 01:39
@artberger

Copy link
Copy Markdown
Collaborator Author

Moved to #1551. The three commits are cherry-picked there, and the description lists each fix with its source.

@artberger artberger closed this Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant