Repository navigation
Conversation
AgentgatewayModel has reported status.parents since v1.7.0. Replace the warning with the status check that main already has. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Art Berger <art.berger@solo.io>
On main, the client sees 'csrf validation failed' (lowercase). Older versions keep 'CSRF validation failed'. Gate the diagram and the example output as pairs. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Art Berger <art.berger@solo.io>
Route and Route rule targets override Service and Backend targets for the backend section. ListenerSet targets have no effect on the backend phase. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Art Berger <art.berger@solo.io>
artberger
marked this pull request as ready for review
November 17, 2026 01:39
Collaborator
Author
|
Moved to #1551. The three commits are cherry-picked there, and the description lists each fix with its source. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
miscellaneous updates while reviewing a bunch of PRs
AI-generated summary
Summary
Fixes stale text that the round 7 pr-tracker triage found outside the bot PRs. No file here is edited by an open pr-tracker PR. #1488 and #1507 are already merged.
Fixes
1. AgentgatewayModel status warning (Kubernetes
latest)File:
content/docs/kubernetes/latest/documentation/llm/models/serve.mdThe page said that AgentgatewayModel does not yet report status. That is false since v1.7.0. The warning is gone. The troubleshooting steps now include the same
status.parentscheck thatmainhas.Source:
controller/pkg/agentgateway/translator/testdata/models/llm-listener.yamlat tagv1.7.0, lines 141-160. It showsstatus.parentswithAccepted: TrueandResolvedRefs: Trueon an AgentgatewayModel.NotAllowedByListenersmessage example is not copied tolatest, because its test fixturenot-allowedkind.yamlis main-only.2. CSRF client-safe error body (shared asset)
File:
assets/agw-docs/pages/security/csrf.mdOn
main, the client body for a CSRF rejection iscsrf validation failed(lowercase). Older versions returnCSRF validation failed. The sequence diagram and the example output are each gated as a whole pair. Theexclude-ifandinclude-iflists use1.0.xto1.7.xplus2.2.x, as the lists forpages/assets do.Source (upstream
agentgateway/agentgateway):crates/agentgateway/src/http/csrf.rsonmain.Csrf::applyreturnsProxyError::CsrfValidationFailed.crates/agentgateway/src/proxy/mod.rs:482onmain.external_message()mapsCsrfValidationFailedto"csrf validation failed".v1.7.0,csrf.rsbuilt a direct 403 response with the bodyCSRF validation failed. Commitdf3e4b43(#4250, Nov 2) is not inv1.7.0.I did not document
AGENTGATEWAY_UNSAFE_EXPOSE_ERROR_DETAILS. It is an unsafe convenience setting.3.
backendrow of the policy precedence table (Kubernetesmain)File:
content/docs/kubernetes/main/documentation/about/policies/target-merge.mdTwo defects in the
backendsection:Gateway < Listener < Service or Backend (targetRef) < Sub-backend (targetRef with sectionName) < Route (targetRef) < Route rule (targetRef) < Backend (inline) < Route backend ref (inline). A sentence with an example explains the Route-over-Backend case.backendtarget. The API server accepts it, but the data plane never reads it for the backend phase. ListenerSet is removed from the row. A note explains that such a policy reportsAttachedand has no effect.Source:
crates/agentgateway/src/store/binds.rs,internal_backend_policies, around lines 1335-1375 onmain. Policies are first-writer-wins in this order: backendRef inline, Backend inline, route rule, route, sub-backend, backend, listener, gateway. There is no ListenerSet lookup. The same chain is inv1.7.0.crates/agentgateway/src/proxy/httpproxy.rs,get_backend_policies. This is the source of the inline order.Runtime test on a Kubernetes cluster with Enterprise agentgateway
2026.11.0. It used a temporary namespace that was deleted afterwards. A go-httpbin app, an HTTPRoute, andAgentgatewayPolicyresources withbackend.transformation.request.setofx-prec. The request header that httpbin echoed showed the winner:servicerouteroutebackendroute-ruleAttached=TruetrafficpolicybackendpolicygatewayNot tested at runtime: sub-backend against Route, and inline against attached policies. Those come from the code and the
backend_policy_merging_precedenceunit test.Not changed
content/docs/kubernetes/latest,1.5.x, and1.6.xcarry the same wrongbackendprecedence row. The chain is identical inv1.7.0.content/docs/kubernetes/1.4.x,1.5.x, and1.6.xllm/models/serve.mdstill have the "does not yet report status" warning. I did not check when status reporting landed.content/docs/standalone/*/documentation/configuration/security/csrf.md) has its own inline copy ofCSRF validation failed. [Automated] Draft docs (agentgateway): proxy: better direct response handling #1505 edits that file, so I left it.Verification
mainand the capitalized text onlatest. Thelatestserve page has the new status step and no old warning. The target-merge page has the new row and note. No raw shortcodes leak.🤖 Generated with Claude Code