Repository navigation
fix: install Mad Libs from a symlinked package path - #19
Merged
Merged
Conversation
npm ci fails with "Missing: <dir>@ from lock file" when --prefix is a path through a symlink, as a demo station under macOS's /tmp is. Resolve the package directory with pwd -P, and run the install test through a symlink so CI covers it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Mad Libs
@ from lock file" wheninstallhook now resolves its package directory withpwd -P. npm 11'snpm cifails with "Missing:--prefixis a path through a symlink, which made the package "Install failed" on a demo station, whose home is under macOS's/tmp.Decide
Nothing.
Ready gate
npm run verify: ok for all three packages.npm run lint: 0 issues in 15 files.npm teston macOS: 190 of 192 pass; the two failures are BirdsBirdBirds tests, covered under Skipped tests.npm error Missing: linked-package@ from lock fileand passes with it.--prefixandnpm ci: this is the only hook that passes its path to npm.setupandcleanuppass theirs tocpandnode, which follow symlinks../installfrom the clone succeeds, and the install test loads the extension under the pinned Pi.npm run demoin boothstrap.sh now lists the package as installed. No model playthrough, since only the install path changed.docs/style/; the hook gets one why-comment.EPIPEon unmodifiedmaintoo. "the watcher reports a bird.png that appears, once" passed onmainin a rerun, so it is flaky. Both are outside this change; CI runs on Linux.Need help on this PR? Tag
@codesmith-botwith what you need.