Repository navigation
test: make two BirdsBirdBirds tests pass on macOS - #21
Merged
Merged
Conversation
The 413 test now sends only the headers, since the server refuses from Content-Length and a client still writing the body can get EPIPE first. Watcher tests repeat their first save until it is reported, since fs.watch on macOS can miss a change made just after it starts. Closes #20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two BirdsBirdBirds tests fail on macOS, and this makes them pass without changing the package. The 413 test now sends only the headers, because the server refuses from Content-Length and a client still writing the body can get
EPIPEfirst. Watcher tests now repeat their first save until it is reported, becausefs.watchon macOS can miss a change made just after it starts. Closes #20.Decide
Nothing. Whether the server should let a client read its 413 before dropping the connection is in #22.
Ready gate
npm run verify: ok for all three packages.npm run lint: 0 issues in 15 files. BirdsBirdBirds tests: 91 of 91 in five runs in a row. Fullnpm teston macOS: 191 of 192; the failure is covered under Skipped tests.main, the 413 test fails on every macOS run withwrite EPIPE. Watcher tests onmainunder background file churn failed in three of eight runs, in three different tests. On this branch, five runs under the same churn pass 8 of 8 each.startWatching. The appears-once, redrawn, burst, and page-server tests now usesaveUntilReported. The complete-PNG test writes its PNG after two quiet waits, and the negative tests can't fail from a missed event, so they are unchanged.docs/style/; the two new helpers each document why they exist./varsymlink. #19 fixes that. CI runs on Linux.Need help on this PR? Tag
@codesmith-botwith what you need.