Skip to content

Ignore directories in secret repositories #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Zhuyuyangyy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ignore directories in secret repositories #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion decouple.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,10 @@ def __init__(self, source='/run/secrets/'):

ls = os.listdir(source)
for file in ls:
with open(os.path.join(source, file), 'r') as f:
path = os.path.join(source, file)
if not os.path.isfile(path):
continue
with open(path, 'r') as f:
self.data[file] = f.read()

def __contains__(self, key):
Expand Down
11 changes: 11 additions & 0 deletions tests/test_secrets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,14 @@ def test_secret_repo_keyerror():

with pytest.raises(KeyError):
repo['UndefinedKey']


def test_secret_repository_ignores_subdirectories(tmpdir):
secret_dir = tmpdir.mkdir('nested')
secret_dir.join('not_a_secret').write('ignored')
tmpdir.join('db_password').write('world')

repository = RepositorySecret(str(tmpdir))

assert repository['db_password'] == 'world'
assert 'nested' not in repository