Repository navigation
Ignore directories in secret repositories - #190
Open
Zhuyuyangyy wants to merge 1 commit into
Open
Zhuyuyangyy wants to merge 1 commit into
Zhuyuyangyy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
RepositorySecretopens every entry returned byos.listdir(source). If the secrets directory contains a subdirectory, construction raisesIsADirectoryError, even when valid secret files are present alongside it.Change
Skip entries that are not regular files before opening them. File symlinks still work because
os.path.isfilefollows symlinks. Normal file contents and read errors are otherwise unchanged.Add a regression with a nested directory and a real
db_passwordfile: the repository must load the password and must not expose the directory as a secret.Validation
The new regression fails on unchanged master with
IsADirectoryError(focused run: 4 passed, 1 failed). After the patch, the focused suite has 5 passed and the full suite has 68 passed on Python 3.12.git show --checkpasses. Other Python versions were not tested.AI assistance was used to investigate, implement, and test this change and draft this description.