Repository navigation
feat(opensearch sink): add first-class OpenSearch sink - #26722
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
Distribution-aware detection keeps OpenSearch’s unrelated major version from enabling typed bulk requests. Execution validation was blocked by an HTTP 502 while downloading the pinned Rust toolchain.
🤖 Bits Code Review · Commit 862522d
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f1b2f33216
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Add a first-class
opensearchsink so OpenSearch users can configure their destination directly. It shares the Elasticsearch sink’s configuration and delivery implementation, with its own reference documentation and examples.Each sink constructor explicitly selects its distribution. With
api_version: auto, the OpenSearch sink selects its compatible bulk API without a version probe; the Elasticsearch sink retains its existing version detection. Explicit API-version overrides remain supported. The shared integration suite continues to build the Elasticsearch implementation directly. Two focused tests exercisetype: opensearchover HTTP and authenticated HTTPS, including default API selection and gzip delivery.References
Closes #11738. Builds on the OpenSearch integration coverage in #24652.
Vector configuration
How did you test this PR?
Tested against OpenSearch 3.6.0 running locally in Colima. All 82 focused tests passed, including 19 integration tests. Separate end-to-end runs with the Vector binary delivered and retrieved all 40 documents over HTTP and authenticated HTTPS, with gzip, default API selection, certificate verification, and required healthchecks.
The focused suite passed through
make testwith the OpenSearch integration feature enabled and unrelated workspace packages excluded. Live Amazon OpenSearch Service and Serverless were not tested.Does this PR include user facing changes?