Repository navigation
ICU-23592 Bound CollationBuilder canonical closure work - #4326
Open
FrankYFTang wants to merge 1 commit into
Open
FrankYFTang wants to merge 1 commit into
FrankYFTang wants to merge 1 commit into
Conversation
FrankYFTang
force-pushed
the
fix-icu-23592
branch
from
October 28, 2026 00:33
2b29613 to
0949d67
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bound
CollationBuildercanonical closure work per rule and per builder in both ICU4C and ICU4J:kClosureLoopLimit = 2400,kClosureWorkLimit = 160000UTF-16 units) and per-builder (kTotalClosureLoopLimit = 4800,kTotalClosureWorkLimit = 320000UTF-16 units) canonical closure budgets inCollationBuilder::addOnlyClosure(U_INPUT_TOO_LONG_ERRORin C++,ICUInputTooLongExceptionin Java), charging non-trivial candidates prior toignorePrefix/ignoreStringwhile keeping NFD-inert mappings free.TestICU23592in both ICU4C (regcoll.cpp) and ICU4J (CollationRegressionTest.java).Checklist