Repository navigation
ci: date the draft announcement like its release note - #14648
Merged
Merged
Conversation
Since #14646 the release note takes its date from the CHANGELOG.md heading, which can be days before the release run, while the draft post was dated the day of the run. release-notes-ready moves a date to the release day only where it still matches the note's, so the post kept the run's date whenever approval came on a later day. The post now starts with the note's date, so both move together. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-up to #14641 and #14646, found on the first real run (14.0.0.GA, run 42964034681, titaniumsdk.com#97).
The two files in the release-notes PR start with different dates:
registry/sdk/14.0.0/release-notes.mdCHANGELOG.mdheading (#14646)content/blog/sdk-14-0-0-ga.mdrelease-notes-readymoves a date to the release day only where it still matches the note's. That's so a date someone set by hand is left alone. So the post keeps the run's date whenever approval comes on a later day.The draft step now passes the note's date to
new-release-post.ts --date. Both files start equal, and both move to the release day together. If the note somehow has no date, the script's own default (today) applies as before.Tested: the workflow parses, and the step's shell, run against a note dated 2026-11-09, produces
--version 14.0.0 --date 2026-11-09.The 14.0.0 run already in progress keeps the workflow it started with, so this applies from the next release. For 14.0.0, the post's date is right if the release is approved today. Otherwise it's one line to fix on #97.
🤖 Generated with Claude Code