Repository navigation
Single neutron energy vertical line option in xs_plotting - #308
Conversation
gonuke
left a comment
gonuke
left a comment
There was a problem hiding this comment.
Thanks @eitan-weinstein - Some cleanup suggestions
| if KZA == dsv_pKZA and MT == flagged_num_to_int(dsv_MT)[0]: | ||
| if KZA == dsv_pKZA and MT == flagged_num_to_int(dsv_MT): |
There was a problem hiding this comment.
I've noticed this in a couple of PRs, was it originally a bug? Is there a PR that just fixes this?
There was a problem hiding this comment.
Good catch. I'll make a small PR just for that bug.
gonuke
left a comment
gonuke
left a comment
There was a problem hiding this comment.
Ready to merge after a rebase for the other small change
5195766 to
264acb6
Compare
264acb6 to
84e7415
Compare
gonuke
left a comment
gonuke
left a comment
There was a problem hiding this comment.
Just one quick design suggestion
| vline_energy, | ||
| color='r', | ||
| alpha=0.4, | ||
| label=f'{vline_energy:.2e} eV', |
There was a problem hiding this comment.
Isn't it more convenient/intuitive for the user to label with the original units?
There was a problem hiding this comment.
Sure, I'll update that.
4bab7a7 to
f1fd3ed
Compare
|
I think the latest commit probably went further than I intended.... My thought was that the plot would still use "eV" for the x-axis, but the |
gonuke
left a comment
gonuke
left a comment
There was a problem hiding this comment.
LGTM - thanks @eitan-weinstein
|
This needs a quick rebase/conflict management & I'll merge |
f365e13 to
34dde0d
Compare
This PR introduces new functionality to
xs_plotting.pyto allow for the plotting of a vertical line at a provided neutron energy to highlight the plot in a specific region. This was motivated by the desire to see the differences in group structure effects for 14.1 MeV neutrons by having a clear marker of where on the plot to focus.