Skip to content

ci: fix python code-type-checking (pyright Node.js bootstrap) - #1072

Merged
bcbogdan merged 1 commit into
masterfrom
ci/pyright-nodejs-extra
Nov 10, 2026
Merged

bcbogdan merged 1 commit into
masterfrom
ci/pyright-nodejs-extra

Conversation

@tamassoltesz

Copy link
Copy Markdown
Contributor

Summary

code-type-checking (python) fails on every PR that triggers it (e.g. #1070, #1071) before it checks a single snippet:

RUN pyright ./snippets
RuntimeError: nodeenv failed; for more reliable node.js binaries try `pip install pyright[nodejs]`

The pip pyright package bootstraps Node.js through nodeenv, which downloads the latest Node binary. Current Node needs libatomic.so.1, which python:3.9-slim doesn't ship:

/root/.cache/pyright-python/nodeenv/bin/node: error while loading shared libraries: libatomic.so.1: cannot open shared object file

This installs pyright[nodejs], which takes Node.js from a pip wheel instead (the fix the error message suggests). The javascript matrix job is cancelled by fail-fast when the python one fails, so this unblocks it too.

Test Plan

  • Reproduced locally: python:3.9-slim + pip install pyright, then pyright → fails with the libatomic.so.1 error above.
  • Same image with pip install "pyright[nodejs]": pyright passes on a well-typed file and reports an error on x: int = "a".
  • This PR's own CI run (changes under scripts/code-type-checking/).

🤖 Generated with Claude Code

pip's pyright bootstraps Node.js through nodeenv, which downloads the
latest Node binary. Current Node needs libatomic.so.1, which
python:3.9-slim doesn't have, so 'pyright ./snippets' fails before
checking anything. pyright[nodejs] installs Node from a pip wheel instead.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 10, 2026 2:52pm UTC

@bcbogdan
bcbogdan merged commit 77c797e into master Nov 10, 2026
14 checks passed
@bcbogdan
bcbogdan deleted the ci/pyright-nodejs-extra branch November 10, 2026 15:10

This branch was successfully deployed

1 active deployment
Preview — 06520ea4 Deployed Nov 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants