Repository navigation
ci: fix python code-type-checking (pyright Node.js bootstrap) - #1072
Merged
Merged
Conversation
pip's pyright bootstraps Node.js through nodeenv, which downloads the latest Node binary. Current Node needs libatomic.so.1, which python:3.9-slim doesn't have, so 'pyright ./snippets' fails before checking anything. pyright[nodejs] installs Node from a pip wheel instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
code-type-checking (python)fails on every PR that triggers it (e.g. #1070, #1071) before it checks a single snippet:The pip
pyrightpackage bootstraps Node.js throughnodeenv, which downloads the latest Node binary. Current Node needslibatomic.so.1, whichpython:3.9-slimdoesn't ship:This installs
pyright[nodejs], which takes Node.js from a pip wheel instead (the fix the error message suggests). Thejavascriptmatrix job is cancelled by fail-fast when the python one fails, so this unblocks it too.Test Plan
python:3.9-slim+pip install pyright, thenpyright→ fails with thelibatomic.so.1error above.pip install "pyright[nodejs]":pyrightpasses on a well-typed file and reports an error onx: int = "a".scripts/code-type-checking/).🤖 Generated with Claude Code