Repository navigation
Retain form values that also appear in query parameters - #4351
Open
wozhenbang2004 wants to merge 2 commits into
Open
wozhenbang2004 wants to merge 2 commits into
wozhenbang2004 wants to merge 2 commits into
Conversation
Signed-off-by: Kayokoi <113896798+wozhenbang2004@users.noreply.github.com>
Signed-off-by: Kayokoi <113896798+wozhenbang2004@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a form parameter has the same name and value as a query parameter,
FormFilterremoves every matching value while rebuilding the request body. For example, a request with?tag=sharedand form datatag=sharedloses the form value.Consume one matching occurrence for each query value, then retain the remaining values in the form body. The wrapped request continues to expose the original query values through its parameter accessors.
Add regressions for a shared value, repeated query and form values, and mixed overlapping values with body order preserved.
Validation:
./mvnw -s .settings.xml -B -U -Pspring -pl spring-cloud-gateway-server-webmvc -am -Dtest=FormFilterTests -Dsurefire.failIfNoSpecifiedTests=false test63a1996: 4 tests, 3 assertion failures, 0 errors.c5fcb4d: 4 tests, 0 failures, 0 errors; Maven build successful.The post-run
git diff --exit-codecheck failed in both jobs because Maven reformatted the same five pre-existing WebSocket files. Neither file changed by this PR appears in that diff. The validation workflow remains confined to a separate branch in the fork.