You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@majek that's too bad! We're testing out the "dev" branch with the heartbeats right now (it seems to be up to date w/ v0.3.4) and it appears to be working.
@3rd-Eden Thanks for the pointer to Primus -- we'll definitely take a look at that!
Hi. This issue has been open for almost 5 years now. It was recently discussed in #297. Is there any plan to implement this feature? The client not being aware of the server disappearing from the network seems to be a major flaw.
What is the "dev" branch mentioned above that has never been merged if one wants to take a look at it?
Reacted by Evan Weible, Evan Dana, Ivan Smirnov, Francois, Loïc Baron, RodJohn and Nicolas Barray
Activity
#67 - tests
sockjs/sockjs-client#67 - API for sending hearbeats to client
sockjs/sockjs-client#67 - test infrastructure
#67 - typo, this was causing major problems previously
#67 - move json sender around, change the interface to more EE-like
#67 - Introducing hacky bus class.
#67 - Basic heartbeater (with hardcoded timers)
#67 - mark polling transports as polling
#67 - heartbeats, get _bus working, use data passed from /info
#67 - renamed fun
#67 - there may be two kinds of heartbeats - empty frame and heartbea…
#67 - updated test code
#67 - rather unfortunate typo.
#67 - move default options to a separate function
#67 - send options to the iframe
#67 - use max_window_time and init_window_size derived from options
glasser commentedon Sep 26, 2012
There was a lot of activity on this issue but it's still open. Does the feature work (and it should be closed)?
hyperthunk commentedon May 14, 2013
@glasser I'm not 100% sure, but I'll discuss with @majek when I get a chance and either merge or close it.
mokesmokes commentedon Jul 23, 2013
Any update?
triopter commentedon Feb 25, 2014
It looks like all of this was on a "dev" branch that never got merged. Is there any plan to merge this into master and release it?
majek commentedon Feb 25, 2014
The fix was way harder then anticipated and required major changes to the codebase, and eventually I gave up. Sorry.
3rd-Eden commentedon Feb 25, 2014
If you use primus on top of sockjs it will send these heartbeat packages for you. From client -> server and the server will automatically disconnect if a heartbeat missing/timed out. See https://github.com/primus/primus#heartbeats-and-latency
So if you really, this might be a viable option.
triopter commentedon Feb 25, 2014
@majek that's too bad! We're testing out the "dev" branch with the heartbeats right now (it seems to be up to date w/ v0.3.4) and it appears to be working.
@3rd-Eden Thanks for the pointer to Primus -- we'll definitely take a look at that!
rikoe commentedon Mar 7, 2017
Hi. This issue has been open for almost 5 years now. It was recently discussed in #297. Is there any plan to implement this feature? The client not being aware of the server disappearing from the network seems to be a major flaw.
What is the "dev" branch mentioned above that has never been merged if one wants to take a look at it?
harshakakumanu commentedon Nov 30, 2017
Are there any plans in implementing this issue? Is there any work around ?