Repository navigation
perf: faster decoding for binary images w/ verified=False - #71
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we are allowed to skip the crc32c check, we can exploit the structure of the vcg for binary images to avoid creating a uint32 CCL plane. This reduces memory consumption and results in faster rendering.
Because this requires skipping a safety check, it is opt in.
On smaller images this didn't make a big impact, but I was rendering hundred of slices of a binary mask at a time that was taking over 6 seconds per render and it went down to a bit over 5. I measured the difference as ~3900 MVx/sec -> ~4500 MVx/sec on my Macbook Pro M3.