Repository navigation
[rfile] Further cleanups + allow setting object titles - #23811
Merged
Merged
Conversation
silverweed
requested review from
guitargeek,
jblomer,
pcanal,
siliataider and
vepadulano
as code owners
October 23, 2026 11:27
This was referenced Oct 23, 2026
jblomer
approved these changes
Oct 23, 2026
Test Results 24 files 24 suites 4d 3h 12m 22s ⏱️ Results for commit e5ee553. ♻️ This comment has been updated with latest results. |
silverweed
force-pushed
the
rfile_cleanups3
branch
from
October 26, 2026 09:14
0ec2fad to
1e2d270
Compare
silverweed
force-pushed
the
rfile_cleanups3
branch
from
October 26, 2026 10:12
1e2d270 to
5ccaf3d
Compare
Then call it from the current WriteObjectAny
silverweed
force-pushed
the
rfile_cleanups3
branch
from
October 27, 2026 09:06
5ccaf3d to
f207e4b
Compare
It seems that on mac15 x86 assertRaises doesn't work consistently. We disable the test on that platform for now.
silverweed
force-pushed
the
rfile_cleanups3
branch
from
October 27, 2026 15:19
03ef9db to
e5ee553
Compare
pcanal
reviewed
Oct 28, 2026
| Int_t WriteTObject(const TObject *obj, const char *name=nullptr, Option_t *option="", Int_t bufsize=0) override; | ||
| Int_t WriteObjectAny(const void *obj, const char *classname, const char *name, Option_t *option="", Int_t bufsize=0) override; | ||
| Int_t WriteObjectAny(const void *obj, const TClass *cl, const char *name, Option_t *option="", Int_t bufsize=0) override; | ||
| Int_t WriteObjectAny(const void *obj, const char *title, const TClass *cl, const char *name, Option_t *option="", Int_t bufsize=0); |
Member
There was a problem hiding this comment.
I can see why we choose this order of argument but at the same time it is a bit unnatural since we have semantically this order:
essential_arg1, decorative_arg, essential_arg2, essential_arg3, optional_behavior_changing_arg1, optional_behavior_changing_arg2).
An alternative could be:
Int_t WriteObjectAny(const void *obj, const TClass *cl, std::pair<const char *, const char *> name_and_title, Option_t *option="", Int_t bufsize=0);
which the usage being only a bit unusual:
dir->WriteObjAny(pointer, cl, { name, title } );
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Is the same as #23807 but without the
TNamed-specific changes (will be a separate PR)Adds some changes+fixes to RFile.
Changes or fixes:
Checklist: