Repository navigation
Reuse parent collection for explicit file arguments - #15251
Open
wpyaoxueros wants to merge 2 commits into
Open
wpyaoxueros wants to merge 2 commits into
wpyaoxueros wants to merge 2 commits into
Conversation
AI assistance: Codex helped implement and validate this change. Human author responsibility was confirmed by Huashuo for the reviewed diff.
wpyaoxueros
force-pushed
the
codex/explicit-parent-cache
branch
from
October 23, 2026 11:26
23d5f6a to
0501b7a
Compare
Fix EncodingWarning under the CI PYTHONWARNDEFAULTENCODING setting. Codex assisted with the test-only update and remote validation.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15221.
Reuse a parent directory's collection report for explicit file arguments unless
--keep-duplicatesrequires fresh collection. A regression selects four of eight sibling test files and checks that the collection hook sees the directory once rather than once per argument.This is an alternative to the existing #15228, which addresses the same collection overhead. That PR uses per-argument occurrence checks; this patch uses the existing
keepduplicatesoption to retain the uncached overlapping-argument path. I welcome maintainer guidance on which approach is preferable.Remote Linux / Python 3.13.16 validation against main
4088e1a84:PYTHONWARNDEFAULTENCODING=1after explicitly specifying UTF-8 in the regression.Windows was not tested locally. The release fragment is named
15251.bugfix.rst.AI disclosure: Codex prepared the code and tests, ran the remote validation and assisted with this description. Huashuo approved author responsibility for the reviewed patch; this does not claim that Huashuo personally ran the tests.