Repository navigation
Fix INTERNALERROR when skipping an item without a line number - #14855
Open
RonnyPfannschmidt wants to merge 2 commits into
Open
RonnyPfannschmidt wants to merge 2 commits into
RonnyPfannschmidt wants to merge 2 commits into
Conversation
RonnyPfannschmidt
force-pushed
the
fix/skip-location-without-line
branch
from
August 11, 2026 10:26
c4bd789 to
c6ecb9a
Compare
pyba-chronographer
Bot
added
the
bot:chronographer:provided
RonnyPfannschmidt
marked this pull request as ready for review
August 11, 2026 11:31
This was referenced Aug 11, 2026
RonnyPfannschmidt
marked this pull request as draft
August 11, 2026 18:49
RonnyPfannschmidt
marked this pull request as ready for review
August 11, 2026 18:51
RonnyPfannschmidt
force-pushed
the
fix/skip-location-without-line
branch
from
August 11, 2026 18:54
c6ecb9a to
1f5ef21
Compare
RonnyPfannschmidt
requested review from
nicoddemus
and
a lite review from Copilot
August 11, 2026 19:48
There was a problem hiding this comment.
Pull request overview
Fixes a crash in TestReport.from_item_and_call when a skipped Item’s reportinfo() has no line number (None), which can happen for non-Python items.
Changes:
- Adjust skip longrepr construction to avoid asserting a line number is present when
_use_item_locationis set. - Add a regression test exercising a custom
Itemthat reports no line number and is skipped via a marker. - Add a changelog entry documenting the fix.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| testing/test_skipping.py | Adds regression coverage for skipping an Item whose reportinfo() line is None. |
| src/_pytest/reports.py | Updates skip-report longrepr construction to avoid crashing when reportinfo() has no line number. |
| changelog/14855.bugfix.rst | Documents the bugfix in the changelog. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
419
to
+423
| path, line = item.reportinfo()[:2] | ||
| assert line is not None | ||
| longrepr = (os.fspath(path), line + 1, r.message) | ||
| # Items which cannot point at a line -- non-Python items may | ||
| # legitimately report None -- get the location without one. | ||
| lineno = line + 1 if line is not None else -1 | ||
| longrepr = (os.fspath(path), lineno, r.message) |
Comment on lines
+1396
to
+1409
| class MyItem(pytest.Item): | ||
| def runtest(self): | ||
| raise AssertionError("should not run") | ||
|
|
||
| def pytest_collect_file(file_path, parent): | ||
| item = MyItem.from_parent(name="foo", parent=parent) | ||
| item.add_marker(pytest.mark.skip(reason="no line here")) | ||
| return item | ||
| """ | ||
| ) | ||
| result = pytester.runpytest("-rs") | ||
| assert "INTERNALERROR" not in result.stdout.str() | ||
| result.stdout.fnmatch_lines(["*no line here*"]) | ||
| result.assert_outcomes(skipped=1) |
RonnyPfannschmidt
force-pushed
the
fix/skip-location-without-line
branch
from
September 15, 2026 11:51
1f5ef21 to
2001520
Compare
RonnyPfannschmidt
force-pushed
the
fix/skip-location-without-line
branch
from
September 23, 2026 07:00
2001520 to
ede7c31
Compare
RonnyPfannschmidt
force-pushed
the
fix/skip-location-without-line
branch
2 times, most recently
from
October 11, 2026 07:26
df6c831 to
f3f4e68
Compare
TestReport.from_item_and_call asserted reportinfo() yields a line number. Items which cannot point at a line -- non-Python items legitimately report None -- crashed with an INTERNALERROR when skipped via a marker. Report the location without a line instead.
RonnyPfannschmidt
force-pushed
the
fix/skip-location-without-line
branch
from
October 14, 2026 20:28
f3f4e68 to
6d680f1
Compare
Pierre-Sassoulas
requested changes
Oct 23, 2026
Pierre-Sassoulas
left a comment
Pierre-Sassoulas
left a comment
Member
There was a problem hiding this comment.
I'm not sure how the automated test exercise the code. It's a python object, it should have a line ? Also we only check that there isn't an internal error and not the actual output
Comment on lines
+447
to
+448
| # Items which cannot point at a line -- non-Python items may | ||
| # legitimately report None -- get the location without one. |
Member
There was a problem hiding this comment.
Suggested change
| # Items which cannot point at a line -- non-Python items may | |
| # legitimately report None -- get the location without one. | |
| # non-Python items may legitimately have no line to point at. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Stack: #14855 -> #14856 -> #14769 -> #14857 -> #14858. Bottom of the chain,
depends on nothing.
TestReport.from_item_and_callassertedreportinfo()yields a line number.Items which cannot point at a line — non-Python items legitimately report
None— crash with anINTERNALERRORwhen skipped via a marker.Reports the location without a line instead.
Standalone bug fix, reproducible on
mainwith any customItem; it sits atthe bottom of the chain only because #14858 needs it, where a non-Python
definition can carry
pytest.param(..., marks=pytest.mark.skip(...)).