Repository navigation
Bump version 0.6.0 - #35
Merged
Merged
Conversation
0xddom
commented
Oct 16, 2026
Collaborator
- Move group core types to haloumi-core
- Backport core changes from integration crate
- Uncomment decompose-in methods
- Port tests
- Remove unnecessary file
- Vacuous commit to trigger CI
- Rollback change
- Fix doc links
- Add serde serialization and deserialization of core types
- Add test helpers
- Vacuous commit to trigger CI
- Vacuous commit to trigger CI 2
- Add extractor core dependencies
- Remove incorrectly ported code
- Restore newlines
- Formatting
- Formatting
- Clippy warnings
- Fix rustdoc errors
- Add missing traits required by extractor
- Add extractor core dependencies
- Add extractor core crate
- Docs
- Formatting
- Add clippy checks in CI
- Fix mistake during rebase
- Fix renamed method
- Basic integration crate
- Fix macro
- Forgot ! in macro
- More macros
- More macros and ports
- Add macro for root Types
- Last batch of macros before next step
- Resolve integration overlap with extractor core
- Formatting
- Remove extractor crate reference in manifest
- Add clippy checks in CI
- Complete trait implementation on bridge type
- Add extractor core dependencies
- Add extractor core crate
- Docs
- Formatting
- Add clippy checks in CI
- Fix mistake during rebase
- Fix renamed method
- Fix clippy issue
- Add extractor core dependencies
- Add extractor core crate
- Docs
- Formatting
- Add clippy checks in CI
- Fix mistake during rebase
- Fix renamed method
- Backport more changes to the integration crate
- Backport more changes to the integration-macros crate
- Backport macros tests
- Remove files
- Remove nightly from formatting ci job
- Fix doc links
- Add extractor and extractor runner crates
- Restore runner integration test dependency
- Add clippy checks in CI
- Add mock halo2 crate for replacing midnight-proofs for testing
- New crates got removed from the manifest for some reason
- Backport changes to ir-gen crate
- Backport changes to synthesis crate
- Complete implementation of updated trait
- Backport changes to llzk params type
- WIP Reworking tests
- Need to rebase
- Backport integration changes that require the extractor
- Adapt fib circuits
- WIP Reworking tests
- Complete haloumi integration support in mock halo2
- Fix test
- Fix lookup tests
- Refactor remaining tests
- Backport remaining preludes implementation
- Add extractor core dependencies
- Fix mistake during rebase
- Basic integration crate
- Fix macro
- Forgot ! in macro
- More macros
- More macros and ports
- Add macro for root Types
- Last batch of macros before next step
- Resolve integration overlap with extractor core
- Formatting
- Remove extractor crate reference in manifest
- Add clippy checks in CI
- Add extractor core dependencies
- Add extractor core crate
- Fix mistake during rebase
- Backport more changes to the integration crate
- Backport more changes to the integration-macros crate
- Backport macros tests
- Remove files
- Fix doc links
- Address clippy warnings
- Install required tool for testing in CI
- Change location of install step
- Make ASAN job target only the interesting part
- haloumi-driver is not named like that yet
- Remove legacy tests in the driver crate
- Update crate name in clippy CI job
- Formatting
- Clippy warnings for ir-gen
- Clippy warnings for extractor
- Fix llzk tests
- haloumi-driver is now named like that
- And the extractor crate doesn't exists yet
- Add llzk re-export
- Clippy warnings for extractor-runner
- Remove examples from copied Value impl
- Remove outdated comment
- Add extractor and extractor runner crates
- Inject crate
- Add inject crate to clippy CI check
- Clippy suggestions
- Extend haloumi-inject patching support
- Add inject-tester developer tool
- Add clippy checks in CI
- Fix broken manifest
- Formatting
- Remove legacy tests
- Clippy warnings for inject
- Fix dead code only on release builds issue
- Backport more serde support
- More macros and ports
- WIP extractor
- Progress up to a lifetime issue
- Another annoying lifetime issue
- Re-enable default LLZK backend
- Ported e2e driver tests to the extractor
- Port the main extraction logic
- Minor fixes
- Minor changes for supporting the MVP
- Improve handling of crate copying and spec registration
- Cleanup tests and API
- First version of the CLI
- Halo2 spec for midnight-proofs 0.8.*
- Reorganize where harness types live
- Rabbit hole...
- ad-hoc extractor now builds e2e on keccak
- Refactor how preludes are handled
- More tweaks to the CLI
- Improve LLZK backend performance
- Remove prelude already ported
- Add error message on bridge error type
- Tweak log messages in backend
- Minor tooling tweaks
- Add serde serialization and deserialization of IR
- Comment out tests
- Change code to avoid unstable feature
- More macros and ports
- Resolve integration overlap with extractor core
- Formatting
- Clippy warnings
- Remove obsolete code that survided the rebase
- Refactor test helper method
- Introduce visitor and rework iterators
- Fix exact_eq
- Formatting
- Update CLI to use new trait
- Fix CLI command
- LLZK clippy warnings
- Read group by their position
- Add tests removed by mistake during rebase
- Fix tests
- Add cargo-haloumi clippy step
- More macros and ports
- WIP extractor
- Progress up to a lifetime issue
- Another annoying lifetime issue
- Ported e2e driver tests to the extractor
- Port the main extraction logic
- Minor fixes
- Minor changes for supporting the MVP
- First version of the CLI
- Reorganize where harness types live
- Rabbit hole...
- Refactor how preludes are handled
- Comment out tests
- Support LLZK fields that are not builtins
- Remove obsolete code that survided the rebase
- Remove incorrectly merged code
- Port the main extraction logic
- Minor fixes
- Rabbit hole...
- Refactor how preludes are handled
- Skip lookup rows where every lookup is disabled
- Remove incorrectly merged code
- Ported e2e driver tests to the extractor
- Rabbit hole...
- Serde tests now finish in a reasonable time
- Emit bytecode as default in LLZK
- Format field is now optional
- Simplify LLZK config
- Remove double import
- Cleanup
- Update tests to new API
- Accept gate callbacks in the extractor
- Bump version
- Propagate version bump across deps
Selective backport of core/src changes from e4df243.
The runner always passed --llzk-field-name to LLZK as a builtin field, so circuits over other primes could not be emitted and a mislabeled field was silently accepted. For example, a circuit over BLS12-381's scalar field labeled `bn254` produced LLZK over BN254's prime. Builtin names are now checked against the circuit's prime and rejected on a mismatch. Any other name defines a field with the circuit's prime. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Lookup IR was instantiated on every row of a group, including rows where all lookup selectors are off, such as the rows of table regions. Those copies fold away later, but only after being fully materialized; on the packed SHA3 circuit IR generation ran out of memory (>22 GB). A lookup is now vacuous on a row when a selector multiplying every one of its inputs is disabled there, and rows where every lookup is vacuous are skipped. A selector that only appears inside a sum, as in `q * a + (1 - q) * b`, does not gate the lookup, and lookups without a gating selector are kept on every row. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
IRGenParams already takes gate callbacks, but the extractor had no way to pass them, so circuits could not customize how their gates are lowered. Add Extractor::extract_circuit_with_callbacks, which takes gate callbacks next to the lookup callbacks; extract_circuit delegates to it without any. Add GateScope::enabled_rows, so that patterns outside ir-gen can find the rows where a gate is enforced. Like the lookup row filter, a row counts as enabled when every selector multiplying the whole polynomial is enabled. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.