Skip to content

CLI phase 2 - #15

Merged
0xddom merged 213 commits into
mainfrom
dani/cargo-haloumi-2
Oct 16, 2026
Merged

0xddom merged 213 commits into
mainfrom
dani/cargo-haloumi-2

Conversation

@0xddom

@0xddom 0xddom commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

No description provided.

@0xddom
0xddom changed the base branch from dani/cargo-haloumi to shankara/skip-vacuous-lookup-rows October 2, 2026 11:18
0xddom and others added 10 commits October 13, 2026 20:00
The runner always passed --llzk-field-name to LLZK as a builtin field, so
circuits over other primes could not be emitted and a mislabeled field was
silently accepted. For example, a circuit over BLS12-381's scalar field
labeled `bn254` produced LLZK over BN254's prime.

Builtin names are now checked against the circuit's prime and rejected on
a mismatch. Any other name defines a field with the circuit's prime.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Lookup IR was instantiated on every row of a group, including rows where
all lookup selectors are off, such as the rows of table regions. Those
copies fold away later, but only after being fully materialized; on the
packed SHA3 circuit IR generation ran out of memory (>22 GB).

A lookup is now vacuous on a row when a selector multiplying every one of
its inputs is disabled there, and rows where every lookup is vacuous are
skipped. A selector that only appears inside a sum, as in
`q * a + (1 - q) * b`, does not gate the lookup, and lookups without a
gating selector are kept on every row.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@0xddom
0xddom force-pushed the shankara/skip-vacuous-lookup-rows branch from 36e5db0 to 3e78151 Compare October 13, 2026 18:01
@0xddom
0xddom force-pushed the dani/cargo-haloumi-2 branch from 85524a8 to 2aa4a22 Compare October 13, 2026 18:01
Base automatically changed from shankara/skip-vacuous-lookup-rows to main October 16, 2026 12:00
@0xddom

0xddom commented Oct 16, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 86485f788c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@0xddom
0xddom merged commit 743efb1 into main Oct 16, 2026
6 checks passed
@0xddom
0xddom deleted the dani/cargo-haloumi-2 branch October 16, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants