Repository navigation
CLI phase 2 - #15
Merged
Merged
CLI phase 2#15
Conversation
Selective backport of core/src changes from e4df243.
0xddom
changed the base branch from
dani/cargo-haloumi
to
shankara/skip-vacuous-lookup-rows
October 2, 2026 11:18
The runner always passed --llzk-field-name to LLZK as a builtin field, so circuits over other primes could not be emitted and a mislabeled field was silently accepted. For example, a circuit over BLS12-381's scalar field labeled `bn254` produced LLZK over BN254's prime. Builtin names are now checked against the circuit's prime and rejected on a mismatch. Any other name defines a field with the circuit's prime. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Lookup IR was instantiated on every row of a group, including rows where all lookup selectors are off, such as the rows of table regions. Those copies fold away later, but only after being fully materialized; on the packed SHA3 circuit IR generation ran out of memory (>22 GB). A lookup is now vacuous on a row when a selector multiplying every one of its inputs is disabled there, and rows where every lookup is vacuous are skipped. A selector that only appears inside a sum, as in `q * a + (1 - q) * b`, does not gate the lookup, and lookups without a gating selector are kept on every row. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
0xddom
force-pushed
the
shankara/skip-vacuous-lookup-rows
branch
from
October 13, 2026 18:01
36e5db0 to
3e78151
Compare
0xddom
force-pushed
the
dani/cargo-haloumi-2
branch
from
October 13, 2026 18:01
85524a8 to
2aa4a22
Compare
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.