Repository navigation
Conversation
clairep94
force-pushed
the
clairep94/test_concurrency
branch
from
October 28, 2026 14:58
8e36e71 to
c71980d
Compare
clairep94
marked this pull request as ready for review
October 30, 2026 21:18
There was a problem hiding this comment.
🟡 Changes recommended
The E2E job still references the protected e2e-tests environment, so it will continue waiting for maintainer approval rather than running automatically.
1 open issue
What changed in this PR
This PR consolidates E2E testing into the main test workflow, making it depend on successful unit tests, typechecks, and linting.
Changes:
- Adds an E2E job for pull requests targeting
developorrelease, preserving the existing test setup and failure artifacts. - Removes the standalone E2E workflow.
- Updates comments to reference the relocated job.
| File | Description |
|---|---|
playwright.config.ts |
Updates comments to reference E2E setup in test.yml. |
.github/workflows/test.yml |
Adds the E2E job with a dependency on the existing checks. |
.github/workflows/e2e.yml |
Removes the standalone E2E workflow. |
.env.e2e |
Updates the comment pointing to Mailpit service port mappings. |
Review effort: Balanced
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
6 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Issue:
Fixes #4284 P4
Demo:
Changes:
I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123