Skip to content

Make e2e tests run after unit tests automatically - #4384

Open
clairep94 wants to merge 4 commits into
developfrom
clairep94/make_e2e_tests_run_after_unit_tests
Open

clairep94 wants to merge 4 commits into
developfrom
clairep94/make_e2e_tests_run_after_unit_tests

Conversation

@clairep94

@clairep94 clairep94 commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Issue:

Fixes #4284 P4

  • removes e2e.yml into test.yml
    • After unit tests, linting and typechecks pass, GHA then runs the e2e tests. If any of the first three tests fail, e2e tests do not run
    • No longer requires approval from maintainers to run
    • Should make passing e2e tests a mandatory check, but might require admin configuration after (@ksen0)

Demo:

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • has no typecheck errors (npm run typecheck)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123
  • meets the standards outlined in the accessibility guidelines

@clairep94
clairep94 force-pushed the clairep94/test_concurrency branch from 8e36e71 to c71980d Compare October 28, 2026 14:58
Base automatically changed from clairep94/test_concurrency to develop October 30, 2026 20:59
@clairep94 clairep94 changed the title Clairep94/make e2e tests run after unit tests Make e2e tests run after unit tests automatically Oct 30, 2026
@clairep94
clairep94 marked this pull request as ready for review October 30, 2026 21:18
@clairep94
clairep94 requested a balanced review from Copilot October 30, 2026 21:21

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The E2E job still references the protected e2e-tests environment, so it will continue waiting for maintainer approval rather than running automatically.

1 open issue
What changed in this PR

This PR consolidates E2E testing into the main test workflow, making it depend on successful unit tests, typechecks, and linting.

Changes:

  • Adds an E2E job for pull requests targeting develop or release, preserving the existing test setup and failure artifacts.
  • Removes the standalone E2E workflow.
  • Updates comments to reference the relocated job.
File Description
playwright.config.ts Updates comments to reference E2E setup in test.yml.
.github/​workflows/​test.yml Adds the E2E job with a dependency on the existing checks.
.github/​workflows/​e2e.yml Removes the standalone E2E workflow.
.env.e2e Updates the comment pointing to Mailpit service port mappings.

Review effort: Balanced

Comment thread .github/workflows/test.yml Resolved
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

This branch was successfully deployed

1 active (outdated) deployment
e2e-tests — 01c5d45b Deployed Oct 30, 2026 by clairep94 via E2E Tests #7069
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make e2e tests mandatory for PR merging

2 participants