Repository navigation
joinOrCreate() should prefer connected peers - #410
Merged
Merged
Conversation
Don't connect to lobbies with disconnected peers. This API is made for quick matches, if you connect to a lobby with disconnected peers this is a bad experience.
koenbollen
approved these changes
Nov 2, 2026
koenbollen
left a comment
koenbollen
left a comment
Collaborator
There was a problem hiding this comment.
For this feature, the 90sec feels very long. It makes sense in the context of updating activity every 30sec.
Idea for future addition for this feature:
What if the client does a quick ping/pong when joining the lobby before emitting the 'joined' event, and if no reply tries again?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't connect to lobbies with disconnected peers. This API is made for quick matches, if you connect to a lobby with disconnected peers this is a bad experience.