[Mary-Clb]

• I have performed a self-review of my code.
• I have added tests (when available) that prove my fix is effective or that my feature works.
• I have updated the CHANGELOG with a short functional description of the fix or new feature.
• This change requires a documentation update.

Description

• It fixes !47622

When searching on the Tags criterion from an itemtype list (e.g. Assets > Computers with "Tags is X"), the results include items that do not have the tag. These items share their ID with an item of another type (e.g. a phone) that does have the tag, and their Tags column is empty. The "is not" and "contains" search types are affected the same way, wrongly excluding or including items.

Since use_subquery is enabled on this search option, the core builds a items_id IN (SELECT ...) subquery on glpi_plugin_tag_tagitems that only takes the link table condition into account and ignores specific_itemtype, so the subquery is not filtered on itemtype. The fix adds an explicit itemtype condition on the link table join, which the core applies to both the join and the subquery. A test covering the equals, notequals and contains search types has been added.

Screenshots (if appropriate):