Repository navigation
Conversation
Contributor
Author
|
Hello |
Rom1-B
requested changes
Nov 9, 2026
Rom1-B
left a comment
Rom1-B
left a comment
Contributor
There was a problem hiding this comment.
Can you add a test that runs the install() methods on an up-to-date schema and checks no same-name changeField() or addPostQuery() is queued? A couple of fieldHasType() assertions (decimal, int unsigned, missing column) would cover the display-width normalization too.
| } | ||
|
|
||
| //Legacy data forwarding below only applies to a pre-1.2.0 table | ||
| $is_legacy = $DB->tableExists("glpi_plugin_order_references_manufacturers"); |
Contributor
There was a problem hiding this comment.
A DB still on plugin 1.2.0 to 1.4.x no longer gets the 1.5.0 entity forwarding with this guard. Probably fine given how old those versions are, just checking it's intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #616
Checklist before requesting a review
Please delete options that are not relevant.
Description