Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
<script>tags printed from PHP remain. Behaviour is unchanged.'csp_compliant' => trueinplugin_version_jamf().Converted patterns:
templates/import.html.twig:onclickon the Import, Discover now and Clear pending imports buttons replaced by jQuery listeners in the template script.templates/merge.html.twig:onclickon the Merge button replaced by a jQuery listener in the template script.templates/mdm_commands.html.twig:onclickon each MDM command button replaced by adata-jamf-mdm-commandattribute and a jQuery listener callingjamfPlugin.onMDMCommandButtonClick().templates/inventory_info.html.twig: the genericon_clickbutton option is replaced by anid; the click is bound in theextra_jsscript.inc/computer.class.phpandinc/mobiledevice.class.php: the "Sync now" button no longer carries anon_clickstring; its listener is bound in the generatedextra_js.inc/mobiledevice.class.php: deprecatedHtml::link()replaced by an escaped<a href>(same markup minus an emptydisplayattribute).Blocked by: glpi-project/glpi#26020 and its 11.0 / 12.0 backports. The minimum GLPI version (
PLUGIN_JAMF_MIN_GLPI) must be bumped to the first CSP-enabled release before merging.Manual test checklist (keep the browser console open, CSP violations are logged there):
Refused to execute inline event handlerorRefused to execute inline scriptmessage in the console on these pages.Screenshots (if appropriate):