Skip to content

Fix: unbreak CI (autoloader suffix, Psalm cache, stray dependency) - #42

Merged
stonebuzz merged 1 commit into
mainfrom
fix/composer-suffix-psalm-cache-drop-stray-dep
Oct 5, 2026
Merged

stonebuzz merged 1 commit into
mainfrom
fix/composer-suffix-psalm-cache-drop-stray-dep

Conversation

@Rom1-B

@Rom1-B Rom1-B commented Oct 5, 2026

Copy link
Copy Markdown

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • It fixes #N/A
  • The "Check composer autoloader suffix" job was failing because composer.json did not declare a unique autoloader suffix, which can cause class loading collisions with other plugins sharing the same GLPI instance. Fixed by adding "autoloader-suffix": "PluginJamf".
  • Psalm has no configured cache directory, which can make it crash with a "mkdir(): Permission denied" error in CI containers depending on the runner's filesystem permissions. Fixed by setting cacheDirectory="var/psalm" in psalm.xml.
  • The "glpi-project/tools" package was declared directly in composer.json require-dev instead of relying on the GLPI monorepo's own vendor directory, duplicating the existing autoload-dev mapping to "../../tools/src/". Removed it, and regenerated composer.lock accordingly.

Screenshots (if appropriate):

@Rom1-B
Rom1-B requested a review from stonebuzz October 5, 2026 07:43
@stonebuzz
stonebuzz merged commit 4feaecf into main Oct 5, 2026
7 checks passed
@stonebuzz
stonebuzz deleted the fix/composer-suffix-psalm-cache-drop-stray-dep branch October 5, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants