stonebuzz · Oct 6, 2026 · Aug 19, 2026 · Sep 4, 2026
diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml
@@ -20,7 +20,7 @@ jobs:
     name: "Generate CI matrix"
     uses: "glpi-project/plugin-ci-workflows/.github/workflows/generate-ci-matrix.yml@v1"
     with:
-      glpi-version: "11.0.x"
+      glpi-version: "12.0.x"
   ci:
     name: "GLPI ${{ matrix.glpi-version }} - php:${{ matrix.php-version }} - ${{ matrix.db-image }}"
     needs: "generate-ci-matrix"

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## [UNRELEASED]
 
+### Added
+
+- GLPI 12 compatibility
+
 ### Fixed
 
 - Fix mobile devices duplication during mobile sync

diff --git a/ajax/cron.php b/ajax/cron.php
@@ -40,7 +40,7 @@
 
 Html::header_nocache();
 
-Session::checkRight('config', UPDATE);
+Session::checkRight(Config::$rightname, UPDATE);
 
 /** @var DBmysql $DB */
 global $DB;

diff --git a/front/menu.php b/front/menu.php
@@ -64,7 +64,7 @@
 
 TemplateRenderer::getInstance()->display('@jamf/menu.html.twig', [
     'links'         => $links,
-    'can_configure' => Session::haveRight('config', UPDATE),
+    'can_configure' => Session::haveRight(Config::$rightname, UPDATE),
     'config_url'    => Config::getFormURL() . '?forcetab=PluginJamfConfig$1',
 ]);
 

diff --git a/hook.php b/hook.php
@@ -75,7 +75,7 @@ function plugin_jamf_getAddSearchOptions($itemtype)
     $opt    = [];
     $plugin = new Plugin();
     if ($plugin->isActivated('jamf') && ($itemtype === 'Computer' || $itemtype === 'Phone')) {
-        $opt = [
+        return [
             '22002' => [
                 'table'         => 'glpi_plugin_jamf_devices',
                 'field'         => 'last_inventory',
@@ -236,9 +236,7 @@ function plugin_jamf_getAddSearchOptions($itemtype)
 
 function plugin_jamf_dashboardCards($cards = [])
 {
-    if (is_null($cards)) {
-        $cards = [];
-    }
+    $cards ??= [];
 
     $cards = array_merge($cards, PluginJamfExtensionAttribute::dashboardCards());
 

diff --git a/inc/abstractdevice.class.php b/inc/abstractdevice.class.php
@@ -35,13 +35,13 @@
  */
 abstract class PluginJamfAbstractDevice extends CommonDBChild
 {
-    public static $itemtype       = 'itemtype';
+    public static string $itemtype       = 'itemtype';
 
-    public static $items_id       = 'items_id';
+    public static string $items_id       = 'items_id';
 
     public static $jamftype_name;
 
-    public static $mustBeAttached = false;
+    public static bool $mustBeAttached = false;
 
     /**
      * Display the extra information for Jamf devices on the main Computer or Phone tab.
@@ -67,7 +67,7 @@ private static function purgeItemCommon(CommonDBTM $item)
         /** @var DBmysql $DB */
         global $DB;
 
-        $jamf_class = static::getJamfItemClassForGLPIItem($item::getType(), $item->getID());
+        $jamf_class = static::getJamfItemClassForGLPIItem($item::class, $item->getID());
         if (!is_string($jamf_class)) {
             return;
         }
@@ -108,7 +108,7 @@ public static function plugin_jamf_purgePhone(Phone $item)
 
         self::purgeItemCommon($item);
         $DB->delete(Item_OperatingSystem::getTable(), [
-            'itemtype' => $item::getType(),
+            'itemtype' => $item::class,
             'items_id' => $item->getID(),
         ]);
     }
@@ -176,7 +176,7 @@ public static function getJamfItemForGLPIItem(CommonDBTM $item, $limit_to_type =
                     ],
                 ],
                 'WHERE' => [
-                    'itemtype' => $item::getType(),
+                    'itemtype' => $item::class,
                     'items_id' => $item->getID(),
                 ],
             ]);
@@ -256,7 +256,7 @@ public function getExtensionAttributes()
                 ],
             ],
             'WHERE' => [
-                $item_ext_table . '.itemtype' => static::getType(),
+                $item_ext_table . '.itemtype' => static::class,
                 'items_id'                    => $this->getID(),
             ],
         ]);

diff --git a/inc/computer.class.php b/inc/computer.class.php
@@ -37,7 +37,7 @@
  */
 class PluginJamfComputer extends PluginJamfAbstractDevice
 {
-    public static $rightname = 'plugin_jamf_computer';
+    public static string $rightname = 'plugin_jamf_computer';
 
     public static $jamftype_name = 'Computer';
 

diff --git a/inc/computersync.class.php b/inc/computersync.class.php
@@ -133,7 +133,7 @@ protected function syncOS(): PluginJamfDeviceSync
                 'operatingsystemversions_id' => $os_version->getID(),
                 'date_creation'              => $_SESSION['glpi_currenttime'],
             ], [
-                'itemtype' => $this->item::getType(),
+                'itemtype' => $this->item::class,
                 'items_id' => $this->item->getID(),
             ]);
         } catch (Exception) {
@@ -186,11 +186,11 @@ protected function syncSoftware(): PluginJamfDeviceSync
                     'is_recursive' => $this->item->fields['is_recursive'],
                 ]);
                 $this->applyDesiredState('Item_SoftwareVersion', [
-                    'itemtype'            => $this->item::getType(),
+                    'itemtype'            => $this->item::class,
                     'items_id'            => $this->item->getID(),
                     'softwareversions_id' => $software_version->getID(),
                 ], [
-                    'itemtype'            => $this->item::getType(),
+                    'itemtype'            => $this->item::class,
                     'items_id'            => $this->item->getID(),
                     'softwareversions_id' => $software_version->getID(),
                     'entities_id'         => $this->item->fields['entities_id'],
@@ -206,7 +206,7 @@ protected function syncSoftware(): PluginJamfDeviceSync
             foreach ($to_remove_software as $to_remove) {
                 $DB->delete(Item_SoftwareVersion::getTable(), [
                     SoftwareVersion::getTable() . '.softwares_id' => $to_remove['softwares_id'],
-                    'itemtype'                                    => $this->item::getType(),
+                    'itemtype'                                    => $this->item::class,
                     'items_id'                                    => $this->item->getID(),
                 ], [
                     'LEFT JOIN' => [
@@ -294,7 +294,7 @@ protected function syncPurchasing(): PluginJamfDeviceSync
             }
 
             $this->db->updateOrInsert(Infocom::getTable(), $infocom_changes, [
-                'itemtype' => $this->item::getType(),
+                'itemtype' => $this->item::class,
                 'items_id' => $this->item->getID(),
             ]);
         } catch (Exception) {
@@ -312,11 +312,11 @@ protected function syncExtensionAttributes(): PluginJamfDeviceSync
     {
         if (!$this->config['sync_general'] || !isset($this->data['extension_attributes'])) {
             $this->status['syncExtensionAttributes'] = self::STATUS_SKIPPED;
-
             return $this;
-        } elseif ($this->config['sync_general'] && $this->jamfplugin_device === null) {
-            $this->status['syncExtensionAttributes'] = self::STATUS_DEFERRED;
+        }
 
+        if ($this->jamfplugin_device === null) {
+            $this->status['syncExtensionAttributes'] = self::STATUS_DEFERRED;
             return $this;
         }
 
@@ -336,7 +336,7 @@ protected function syncExtensionAttributes(): PluginJamfDeviceSync
                     $this->db->updateOrInsert(PluginJamfItem_ExtensionAttribute::getTable(), ['value' => $attr['value']], [
                         'glpi_plugin_jamf_extensionattributes_id' => $attr_match['id'],
                         'items_id'                                => $this->jamfplugin_device->getID(),
-                        'itemtype'                                => $this->jamfplugin_device::getType(),
+                        'itemtype'                                => $this->jamfplugin_device::class,
                     ]);
                 }
             }
@@ -398,11 +398,11 @@ protected function syncNetwork(): PluginJamfDeviceSync
                     'comment'                    => 'Created by Jamf Plugin for GLPI',
                 ]);
                 $item_wifi = $this->createOrGetItem('Item_DeviceNetworkCard', [
-                    'itemtype'              => $this->item->getType(),
+                    'itemtype'              => $this->item::class,
                     'items_id'              => $this->item->getID(),
                     'devicenetworkcards_id' => $wifi->getID(),
                 ], [
-                    'itemtype'              => $this->item->getType(),
+                    'itemtype'              => $this->item::class,
                     'items_id'              => $this->item->getID(),
                     'devicenetworkcards_id' => $wifi->getID(),
                     'is_dynamic'            => 1,
@@ -411,12 +411,12 @@ protected function syncNetwork(): PluginJamfDeviceSync
                 ]);
 
                 $netport = $this->createOrGetItem('NetworkPort', [
-                    'itemtype'           => $this->item->getType(),
+                    'itemtype'           => $this->item::class,
                     'items_id'           => $this->item->getID(),
                     'instantiation_type' => 'NetworkPortWifi',
                     'logical_number'     => 0,
                 ], [
-                    'itemtype'                    => $this->item->getType(),
+                    'itemtype'                    => $this->item::class,
                     'items_id'                    => $this->item->getID(),
                     'instantiation_type'          => 'NetworkPortWifi',
                     'logical_number'              => 0,
@@ -442,7 +442,7 @@ protected function syncNetwork(): PluginJamfDeviceSync
                     'entities_id'  => $this->item->fields['entities_id'],
                     'itemtype'     => 'NetworkName',
                     'items_id'     => $network_name->getID(),
-                    'mainitemtype' => $this->item->getType(),
+                    'mainitemtype' => $this->item::class,
                     'mainitems_id' => $this->item->getID(),
                     'is_dynamic'   => 1,
                 ]);
@@ -451,7 +451,7 @@ protected function syncNetwork(): PluginJamfDeviceSync
                         'entities_id'  => $this->item->fields['entities_id'],
                         'itemtype'     => 'NetworkName',
                         'items_id'     => $network_name->getID(),
-                        'mainitemtype' => $this->item->getType(),
+                        'mainitemtype' => $this->item::class,
                         'mainitems_id' => $this->item->getID(),
                         'is_dynamic'   => 1,
                         'name'         => $general['ip_address'],
@@ -500,7 +500,7 @@ protected function syncGeneralJamfPluginItem(): PluginJamfDeviceSync
                 $this->commondevice_changes['enroll_date'] = $enroll_date;
             }
 
-            $this->commondevice_changes['itemtype']      = $this->item::getType();
+            $this->commondevice_changes['itemtype']      = $this->item::class;
             $this->commondevice_changes['items_id']      = $this->item->getID();
             $this->commondevice_changes['jamf_items_id'] = $general['id'];
             $this->commondevice_changes['udid']          = $general['udid'];
@@ -538,11 +538,11 @@ protected function syncComponents(): PluginJamfDeviceSync
                 'is_recursive'     => '1',
             ]);
             $this->applyDesiredState('Item_DeviceFirmware', [
-                'itemtype'           => $this->item::getType(),
+                'itemtype'           => $this->item::class,
                 'items_id'           => $this->item->getID(),
                 'devicefirmwares_id' => $boot_rom->getID(),
             ], [
-                'itemtype'           => $this->item::getType(),
+                'itemtype'           => $this->item::class,
                 'items_id'           => $this->item->getID(),
                 'devicefirmwares_id' => $boot_rom->getID(),
                 'is_deleted'         => 0,
@@ -558,12 +558,12 @@ protected function syncComponents(): PluginJamfDeviceSync
                 foreach ($disk['partitions'] as $partition) {
                     // Volume
                     $this->applyDesiredState(Item_Disk::class, [
-                        'itemtype'   => $this->item::getType(),
+                        'itemtype'   => $this->item::class,
                         'items_id'   => $this->item->getID(),
                         'mountpoint' => '',
                         'name'       => $partition['name'],
                     ], [
-                        'itemtype'    => $this->item::getType(),
+                        'itemtype'    => $this->item::class,
                         'items_id'    => $this->item->getID(),
                         'name'        => $partition['name'],
                         'mountpoint'  => '',
@@ -712,7 +712,7 @@ public static function import(string $itemtype, int $jamf_items_id, $use_transac
         if ($items_id) {
             // Link
             $r = $DB->insert('glpi_plugin_jamf_devices', [
-                'itemtype'         => $item::getType(),
+                'itemtype'         => $item::class,
                 'items_id'         => $items_id,
                 'udid'             => $jamf_item['general']['udid'],
                 'jamf_type'        => static::$jamf_itemtype,

diff --git a/inc/config.class.php b/inc/config.class.php
@@ -36,20 +36,20 @@
  */
 class PluginJamfConfig extends CommonDBTM
 {
-    protected static $notable = true;
+    protected static bool $notable = true;
 
     public function getTabNameForItem(CommonGLPI $item, $withtemplate = 0)
     {
-        if (!$withtemplate && $item::getType() === Config::class) {
-            return self::createTabEntry(__s("Jamf", "jamf"), 0, $item::getType(), self::getIcon());
+        if (!$withtemplate && $item::class === Config::class) {
+            return self::createTabEntry(__s("Jamf", "jamf"), 0, $item::class, self::getIcon());
         }
 
         return '';
     }
 
     public function showForm($ID = -1, array $options = [])
     {
-        if (!Session::haveRight('config', UPDATE)) {
+        if (!Session::haveRight(Config::$rightname, UPDATE)) {
             return false;
         }
 
@@ -73,7 +73,7 @@ public function showForm($ID = -1, array $options = [])
 
     public static function displayTabContentForItem(CommonGLPI $item, $tabnum = 1, $withtemplate = 0)
     {
-        if ($item::getType() === Config::class) {
+        if ($item::class === Config::class) {
             return (new self())->showForm();
         }
 
@@ -95,9 +95,7 @@ public static function undiscloseConfigValue($fields)
     public static function getConfig(bool $force_all = false): array
     {
         static $config = null;
-        if ($config === null) {
-            $config = Config::getConfigurationValues('plugin:Jamf');
-        }
+        $config ??= Config::getConfigurationValues('plugin:Jamf');
 
         if (!$force_all) {
             return self::undiscloseConfigValue($config);

diff --git a/inc/connection.class.php b/inc/connection.class.php
@@ -90,9 +90,7 @@ public function setConnectionConfig($jssserver, $jssuser, $jsspassword)
     public function getServerVersion()
     {
         static $version = null;
-        if (is_null($version)) {
-            $version = PluginJamfAPI::getJamfProVersion();
-        }
+        $version ??= PluginJamfAPI::getJamfProVersion();
 
         return $version;
     }

diff --git a/inc/dbutil.class.php b/inc/dbutil.class.php
@@ -52,19 +52,7 @@ public static function dropTableOrDie(string $table, string $message = '')
             return true;
         }
 
-        $res = $DB->doQuery('DROP TABLE' . $DB::quoteName($table));
-        if (!$res) {
-            //TRANS: %1$s is the description, %2$s is the query, %3$s is the error message
-            $message = sprintf(
-                _x('error', '%1$s - Error during the drop of the table %2$s - Error is %3$s', 'jamf'),
-                $message,
-                $table,
-                $DB->error(),
-            );
-            throw new RuntimeException($message);
-        }
-
-        return $res;
+        return $DB->doQuery('DROP TABLE' . $DB::quoteName($table));
     }
 
     public static function truncate($table)

diff --git a/inc/devicesync.class.php b/inc/devicesync.class.php
@@ -314,12 +314,12 @@ protected function finalizeSync()
             'id' => $this->item->getID(),
         ] + $this->item_changes);
         foreach ($this->extitem_changes as $key => $value) {
-            PluginJamfExtField::setValue($this->item::getType(), $this->item->getID(), $key, $value);
+            PluginJamfExtField::setValue($this->item::class, $this->item->getID(), $key, $value);
         }
 
         // Update or Add Jamf Item
         $this->db->updateOrInsert('glpi_plugin_jamf_devices', $this->commondevice_changes, [
-            'itemtype' => $this->item::getType(),
+            'itemtype' => $this->item::class,
             'items_id' => $this->item->getID(),
         ]);
         $device_id = -1;
@@ -328,7 +328,7 @@ protected function finalizeSync()
             'SELECT' => ['id'],
             'FROM'   => 'glpi_plugin_jamf_devices',
             'WHERE'  => [
-                'itemtype' => $this->item::getType(),
+                'itemtype' => $this->item::class,
                 'items_id' => $this->item->getID(),
             ],
         ]);
@@ -340,7 +340,7 @@ protected function finalizeSync()
             'glpi_plugin_jamf_devices_id' => $device_id,
         ]);
 
-        if ($this->jamfplugin_device === null || empty($this->jamfplugin_device->fields)) {
+        if ($this->jamfplugin_device === null || $this->jamfplugin_device->fields === []) {
 
             if (!is_a(static::$jamfplugin_itemtype, CommonDBTM::class, true)) {
                 throw new RuntimeException('Invalid jamfplugin_itemtype: ' . static::$jamfplugin_itemtype);
@@ -351,7 +351,7 @@ protected function finalizeSync()
                 'SELECT' => ['id'],
                 'FROM'   => static::$jamfplugin_itemtype::getTable(),
                 'WHERE'  => [
-                    'itemtype' => $this->item::getType(),
+                    'itemtype' => $this->item::class,
                     'items_id' => $this->item->getID(),
                 ],
                 'LEFT JOIN' => [