Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
Summary: the plugin no longer relies on inline event handlers, so it keeps working once GLPI sends the Content Security Policy (
script-src 'nonce-<value>' 'unsafe-eval').The behaviour is unchanged: the same JavaScript functions are called with the same arguments.
Converted patterns:
templates/tickets/consume.html.twigonchangeon the "Consume a voucher ?" slider (additional_attributes): removed, bound withaddEventListener('change')in the template's own<script>block, callingshowCreditDiv<rand>(this.value).on_changeon the voucher dropdown: removed, bound with jQuery.on('change')on#dropdown_plugin_credit_entities_id<rand>(select2 fires jQuery events), callinggetQuantityRemaining<rand>(this.value).templates/tickets/form.html.twigon_changeon the voucher dropdown: removed, bound with jQuery.on('change')on#dropdown_plugin_credit_entities_id<rand>, callinggetQuantityRemainingForm<rand>(this.value, this). The dropdown now receives the templaterandexplicitly so the id is known.No PHP output of
<script>or handler attributes was found. The two<script>blocks are literal Twig, so the nonce is added at compile time.Blocked by
PLUGIN_CREDIT_MIN_GLPImust be bumped to the first CSP-enabled 11.0 release before merging. This PR adds'csp_compliant' => trueas a draft and does not change the minimum version yet.Manual test checklist
Keep the browser console open. A CSP violation shows as
Refused to execute inline event handlerorRefused to execute inline script. None should appear.Screenshots (if appropriate):