Repository navigation
Removed TimeProvider. - #171
Merged
Johannestegner merged 1 commit intoNov 11, 2026
Merged
Conversation
Added dependency on Bcl.TimeProvider for net48 and netstandard2.1 (in main project). Signed-off-by: Johannes Tegnér <johannes@jitesoft.com>
Johannestegner
marked this pull request as ready for review
November 11, 2026 14:21
rasmusbe
reviewed
Nov 11, 2026
rasmusbe
left a comment
Member
There was a problem hiding this comment.
Looks good to me. CI is green on all targets, and since Personnummer.TimeProvider was added after 3.5.1 and never shipped in a release, removing it isn't a breaking change for consumers.
Two small things in Personnummer.csproj:
- The comment says "older net versions and netfx", but netstandard2.1 is neither. Something like "Targets without System.TimeProvider (before net8.0)" would match what the condition does. If you'd rather not list the TFMs by name,
!$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net8.0'))covers targets added later too. - Microsoft.Bcl.TimeProvider 11.0.0 pulls in Microsoft.Bcl.AsyncInterfaces 11.0.0, plus System.ValueTuple on net48, so consumers on those targets get a slightly larger dependency tree and a higher minimum version of those packages. I'd mention that in the release notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request removes the internally created
TimeProviderclass (which was used as a drop-in replacement of the official one).We now add the
Microsoft.Bcl.TimeProviderpackage as a dependency on net48 and netstandard2.1.