Skip to content

feat(validation): use SDK exports for OCI client and model resolution and validation - #557

Merged
dustin-sale merged 1 commit into
oracle:mainfrom
gebhardtr:rigebha/cloud-sdk-export-resolution
Nov 12, 2026
Merged

dustin-sale merged 1 commit into
oracle:mainfrom
gebhardtr:rigebha/cloud-sdk-export-resolution

Conversation

@gebhardtr

Copy link
Copy Markdown
Member

Resolve client and model names through the installed OCI SDK's service exports and model mappings. Validate operation and explicit model identities before constructors, and reuse validated objects for error hints instead of resolving rejected input again.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@oracle-contributor-agreement oracle-contributor-agreement Bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 11, 2026
@gebhardtr gebhardtr changed the title feat(validation): use SDK exports for OCI client and model resolution and validate feat(validation): use SDK exports for OCI client and model resolution and validation Nov 11, 2026
@gebhardtr
gebhardtr marked this pull request as ready for review November 11, 2026 23:10

@dustin-sale dustin-sale left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by @dustin-sale via Codex.

Requested changes

No blocking changes requested.

Additional review notes

None.

Validation

Cloud tests passed: 302 tests, 94.26% branch-inclusive coverage.
Repository lint, Cloud lock/build/install checks, and coverage aggregation passed.
An additional compatibility probe verified all 323 exported clients and 16,327
exported model classes in OCI SDK 2.185.1. No live OCI calls were executed.

No inline comments.

Resolve client and model names through the installed OCI SDK's service exports and model mappings. Validate operation and explicit model identities before constructors, and reuse validated objects for error hints instead of resolving rejected input again.

Signed-off-by: Richard Gebhardt <richard.gebhardt@oracle.com>
@gebhardtr
gebhardtr force-pushed the rigebha/cloud-sdk-export-resolution branch from f377608 to 2b83003 Compare November 12, 2026 19:06
@dustin-sale
dustin-sale merged commit 3f90e51 into oracle:main Nov 12, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants