Repository navigation
fix(cloud): restrict SDK resolution to a trusted catalog - #556
Closed
dustin-sale wants to merge 1 commit into
Closed
dustin-sale wants to merge 1 commit into
dustin-sale wants to merge 1 commit into
Conversation
dustin-sale
marked this pull request as ready for review
November 10, 2026 20:07
dustin-sale
requested review from
AlaaShaker,
gebhardtr,
irfan-ahmed,
krisrice and
robander
as code owners
November 10, 2026 20:07
dustin-sale
force-pushed
the
codex/cloud-sdk-resolution
branch
from
November 10, 2026 20:44
b574f19 to
db37c93
Compare
Member
|
what prevents someone from just updating the on-disk catalog? and how did we determine what is "trusted"? |
robander
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Constrain OCI Cloud SDK resolution to a committed catalog before importing client or model modules. The current dispatcher checks namespace/class-name patterns before importing, then validates membership afterward; parameter-error hints can also repeat resolution of rejected input.
This change:
sdk_versionfrom the exactpyproject.tomlpin and checks the installed SDK, lockfile and reviewed schema-exception version. Builds, installation and startup consume the committed resource without regeneration.Compatibility: Supported service operations, aliases, coercion, pagination and caller-specific authentication remain supported. Infrastructure/helper/vendor classes, composite wrappers, private/unlisted operations and unknown/conflicting model hints are rejected. Catalog membership constrains Python resolution; OCI permissions and write-policy defaults remain unchanged.
Dependencies: No dependent PRs or dependency upgrades. The OCI SDK pin and Common dependency are unchanged. Nonroot execution and immutable application/SDK import locations remain deployment requirements; this PR documents them without changing a deployment.
Tracking reference: Not supplied.
Type of change
How Has This Been Tested?
Validation covers the committed branch contents at
b574f19. Run from the repository root with the pinned tools:The configured package coverage gate is 90%. One existing upstream Authlib deprecation warning remains. The generator's remaining unmeasured line is its CLI entrypoint, which subprocess tests exercise outside the parent coverage process.
Clean wheel/sdist/rebuilt-wheel installations and 18 invalid-catalog startup checks also passed during implementation, before the final package-version metadata and test-only follow-ups. That installation matrix has not been rerun against the final 2.3.1 artifacts. Live OCI calls, HTTP token exchange and deployed filesystem protections were not exercised.
Test Configuration:
Checklist: