Skip to content

allow global/collection editors to grant upload access to titles - #617

Merged
elfkuzco merged 1 commit into
mainfrom
title-uploader-permissions
Oct 27, 2026
Merged

elfkuzco merged 1 commit into
mainfrom
title-uploader-permissions

Conversation

@elfkuzco

@elfkuzco elfkuzco commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Changes

  • allow collection/global editors to grant access to their titles to accounts with title-uploader role
  • add endpoint to retrieve list of title uploaders that can be granted access to a specific title. This is needed as collection editors don't have access to read/list accounts and it's simpler than granting them access to accounts
  • use new endpoint for retrieving available title uploaders in UI
  • use UUID suffix whe constructing username as faker sometimes generate same name

This closes #616

@elfkuzco
elfkuzco added this pull request to stack #618 October 26, 2026 10:21
@elfkuzco elfkuzco self-assigned this Oct 26, 2026
@elfkuzco
elfkuzco requested a review from benoit74 October 26, 2026 10:23
@codecov

codecov Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.99%. Comparing base (7e0f059) to head (ab36ca7).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #617      +/-   ##
==========================================
+ Coverage   80.94%   80.99%   +0.05%     
==========================================
  Files          78       78              
  Lines        5128     5142      +14     
  Branches      668      668              
==========================================
+ Hits         4151     4165      +14     
  Misses        776      776              
  Partials      201      201              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benoit74 benoit74 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from upgrade-dependencies to main October 27, 2026 15:06
@elfkuzco
elfkuzco force-pushed the title-uploader-permissions branch from 28cb318 to ab36ca7 Compare October 27, 2026 15:10
@elfkuzco
elfkuzco merged commit eb02617 into main Oct 27, 2026
5 checks passed
@elfkuzco
elfkuzco deleted the title-uploader-permissions branch October 27, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

An editor must be able to grant upload permission on a given title

2 participants