Repository navigation
Assign all install rules to an explicit "umf" component - #1629
Merged
lukaszstolarczuk merged 1 commit intoNov 4, 2026
Merged
Conversation
Contributor
Author
|
This is an additional update for umf component; issue was encountered in intel/llvm repo and fixed there independently (intel/llvm#23712). |
lukaszstolarczuk
force-pushed
the
add-component-umf
branch
from
November 3, 2026 16:34
59db080 to
8106a2f
Compare
kswiecicki
approved these changes
Nov 4, 2026
Contributor
Author
|
tested positive on SYCL CI: |
Previously most install() rules had no COMPONENT, so they were assigned to CMAKE_INSTALL_DEFAULT_COMPONENT_NAME. When UMF is embedded via FetchContent/add_subdirectory, the parent project may override that default (e.g. LLVM sets it to the external project name since intel/llvm@8673c6f2cda8), silently moving UMF's install set into a component the parent deploys. This broke intel/llvm nightly builds by leaking a static libumf.a and umf-config.cmake into the SYCL toolchain. An explicit COMPONENT is immune to such overrides. Plain full installs (cmake --install / make install) are unaffected, and component-based installs can now select "umf" directly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Łukasz Stolarczuk <lukasz.stolarczuk@intel.com>
lukaszstolarczuk
force-pushed
the
add-component-umf
branch
from
November 4, 2026 10:27
8106a2f to
58759fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously most install() rules had no COMPONENT, so they were assigned to CMAKE_INSTALL_DEFAULT_COMPONENT_NAME. When UMF is embedded via FetchContent/add_subdirectory, the parent project may override that default (e.g. LLVM sets it to the external project name since intel/llvm@8673c6f2cda8), silently moving UMF's install set into a component the parent deploys. This broke intel/llvm nightly builds by leaking a static libumf.a and umf-config.cmake into the SYCL toolchain.
An explicit COMPONENT is immune to such overrides. Plain full installs (cmake --install / make install) are unaffected, and component-based installs can now select "umf" directly.