Repository navigation
[test] sanitizer test - #65
Closed
bratpiorka wants to merge 3 commits into
Closed
bratpiorka wants to merge 3 commits into
bratpiorka wants to merge 3 commits into
Conversation
A UsmBox could be freed while a copy or fill that uses it was still running, which breaks the precondition of sycl::free that no enqueued or in-progress command uses the memory. Safe code could do this by dropping an allocation before its zero fill finished, or by dropping the source or destination of a copy before the copy finished. Have each UsmBox record the events of the copies and fills that use it, and wait for them before freeing the memory. If waiting fails, the memory is leaked instead, since a command may still be using it. Signed-off-by: Zhiwei Liang <zhiwei.liang@zliang.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sanitizer test