Repository navigation
fix signed overflow reading long digit strings in as_i, <i> and <t> - #481
Merged
Merged
Conversation
ohler55
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ox::Sax::Value#as_i, object mode<i>, and both copies ofparse_double_time(as_timeand object mode<t>) add up document digits in alongortime_twith no overflow check, so a long digit string is signed overflow and wraps to whatever the document wants:as_ion9223372036854775808gives-9223372036854775808,18446744073709551617gives1from bothas_iand<i>, andas_timeon18446744073709551617.5gives1970-01-01 00:00:01.5. the integer paths now stop accumulating beforeLONG_MAX, still check the rest of the digits, and hand the text torb_cstr_to_inumso the caller gets the real Integer (which also covers values past 2**31 on windows, where long is 32 bits), and the time paths returnQnilonce the seconds would pass the largesttime_t, so they fall through toTime.parse, which raises the same way it already does for non-numeric text. ubsan flagged all four sites before the change andtest/number_overflow_test.rbcovers them.