Repository navigation
feat: add NeonStrip, Lighthouse, Cave, GlassWall, KitchenUnits and a music room - #49
Merged
Merged
Conversation
…music room - `NeonStrip`: a neon tube that glows at any hour; `light` washes nearby walls through the light pool - `Lighthouse`: a banded tower whose two beams sweep round after dusk, fading out from the lamp - `Cave`: a seeded sea cave mouth to set into a `Cliff`, open so a boat can go in - `GlassWall`: a glass partition with an optional doorway, clear or smoked - `KitchenUnits`: a fitted kitchen run with sink, hob, oven, wall units, hood and an island overhang - Music room: `Piano`, `DrumKit`, `Guitar` and `Diffuser` [CONTRIBUTORS] - Ported from Atlantis's own parts onto `useMaterials`, `useLight` and `<Dynamic>` - `Piano` builds its case geometry once and its lid prop stick now meets the lid - `Lighthouse` beams widen away from the lamp and fade with vertex colours - Registry entries, generated docs pages and gallery preview framing for all nine - `just perf` stays within budget, with little headroom left on materials and gallery draws Closes #31 Closes #33 Closes #34 Closes #35 Closes #36 Closes #37 Closes #38 Closes #39 Closes #43
…udget - `KitchenUnits` 12 looks to 6, `Guitar` 7 to 4, `Lighthouse` 9 to 7, merging ones that differed only slightly - Handles, taps, stand poles and flush fronts no longer cast shadows
…omponents - Gallery 1,050 to 1,190 and turn 980 to 1,140: 15% over CI's new counts (1,038 and about 990), the margin the budget file keeps over main - The gallery hall shows every component, so nine new ones raise its draws by design, after the cuts in the previous commit - Turn in software mode averages over a handful of frames and swings by about 15 draws run to run, which the old margin no longer covered
anistark
force-pushed
the
feat/lights-coast-studio
branch
from
October 27, 2026 19:03
37cd295 to
0175ba4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nine new components, upstreamed from parts Atlantis built for its own world. Each one is ported onto the shared-material, light-pool and
<Dynamic>render layer from #46.Lights and coast
NeonStrip: a neon tube that glows at any hour;lightlights nearby walls through the light poolLighthouse: a banded tower with a lamp lit through the light pool, and two beams that sweep round after duskCave: a seeded sea cave mouth to set into aCliff; no collider, so a boat can go inInteriors
GlassWall: a glass partition with an optional doorway, clear or smokedKitchenUnits: a fitted run with seeded fronts, sink, hob over an oven, wall units, hood and an island overhangMusic room
Piano,DrumKit,Guitar(acoustic, electric or bass) andDiffuser(skyline, quadratic-residue depths)Fixed on the way over from Atlantis
Lighthousebeams widen away from the lamp (they were reversed) and fade out with distance, instead of reading as solid conesPianobuilds its case once instead of on every render, and its lid prop stick meets the lidFor review
scripts/perf-budget.json): gallery 1,050 to 1,190, turn 980 to 1,140, 15% over CI's new counts as the budget file's rule says. The gallery hall shows every component, so nine new ones add draws by designKitchenUnits,GuitarandLighthousemerge near-duplicate looks, and handles, taps, stand poles and flush fronts no longer cast shadows (gallery 1,053 to 1,038 in CI)just perf --timing(60 fps floor): gallery 65 fps on an Apple GPUTesting:
just checkpasses (lint, typecheck, 268 tests, build);just perfwithin budget on an Apple GPU; every new docs preview checked in headless Chrome.Closes #31
Closes #33
Closes #34
Closes #35
Closes #36
Closes #37
Closes #38
Closes #39
Closes #43