Repository navigation
Close the shop-deleted notice on sign-out - #87
Merged
Merged
Conversation
In MyTurnTagCreator-Android, "Organization switched successfully." stayed over the sign-in screen after Settings > Sign Out; the same mechanism here keeps "Shop deleted" up after a sign-out, since nothing dismissed the root snackbar. showNoticeStoredForLaunch, which shows the notices stored before the app restarts itself, now cancels the notice when the shopkeeper signs out, which dismisses its snackbar. The notices that explain a sign-out (email changed, account deleted) are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YDK5huvuRECyVrsQEdTN9q
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the one issue that applies here from the MyTurnTagCreator-Android organization tests (dadachi/MyTurnTagCreator-Android#143). The bug: a success snackbar shown after the app restarted itself stayed over the sign-in screen after sign-out. In this app that notice is "Shop deleted".
showNoticeStoredForLaunchnow cancels the notice when the shopkeeper signs out, which dismisses its snackbar. The notices that explain a sign-out (email changed, account deleted) are unchanged. The newStoredNoticeTestcases were seen red with the fix reverted.The other four issues don't apply to this repo: it has no billing bypass, no organizations tab or slots, no personal organization alert, and no "an user" text.
Checks
spotlessCheck,:app:lintDebug,:app:minifyReleaseWithR8andtestpassed locally🤖 Generated with Claude Code
https://claude.ai/code/session_01YDK5huvuRECyVrsQEdTN9q