Repository navigation
Pin h5p-author 0.9.5 - #36
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
No issues found across 2 files
Tip: cubic could auto-approve low-risk PRs like this, if it thinks it's safe to merge. Learn more
View guided diff | Turn on auto-fix | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35.
h5p-author 0.9.5 (missing-elements/h5p-offline-player#191) changes only the skill (
SKILL.md). When a chat builds the package itself, it now hands over the source as a file, the build page's link that carries the source, and where to say how it went. A source that names files gets no link, and the build routes are told apart by what the environment can do. The build is unchanged.What changes
package.jsonand the lockfile move@missing-elements/h5p-authorfrom 0.9.4 to 0.9.5. The lockfile change is the five lines of that entry, with the integrity npm gives for 0.9.5; its dependencies are the same as 0.9.4's./h5p/skill/SKILL.mdis 0.9.5's. The brief, the licence and the 32 type files, under/h5p/skill/and/h5p/build/types/, stay as in 0.9.4: the two tarballs differ only inSKILL.mdandpackage.json./h5p/skill/index.jsonand/h5p/bundles/index.jsonsay author 0.9.5, with the same 55 bundles from pack 1.1.0.feedback-headingid that the line 0.9.5 prints points to.Tested
pnpm install --frozen-lockfile,pnpm buildandpnpm typecheckpass. The site has no e2e tests since 0063e52, so none ran._site/h5p/are byte for byte the files of the published 0.9.5 tarball:skill/SKILL.md,LICENSE,references/authoring.md, and all 32 type files under both/h5p/skill/and/h5p/build/types/. No file in the built site names 0.9.4.Summary by cubic
Pins
@missing-elements/h5p-authorto 0.9.5. The only change in 0.9.5 is toSKILL.md: when a chat builds the package itself, it now hands over the source as a file, the link carrying the source, and where to report how it went; a source that names files gets no link. The build and the dependency set are identical to 0.9.4.Verified with
pnpm install --frozen-lockfile,pnpm build, andpnpm typecheck.Written for commit 32053b5. Summary will update on new commits.