Repository navigation
fix(author): the build page route hands over the source file, only the tool writes the .h5p - #195
Open
alekswebnet wants to merge 1 commit into
Open
alekswebnet wants to merge 1 commit into
alekswebnet wants to merge 1 commit into
Conversation
…e tool writes the .h5p In the build page route the source goes over as a file too, where the chat can give one: 2 of ChatGPT's 3 links broke as it wrote them out, and its .source.json built every time. The skill's opening says only the build tool writes the .h5p: ChatGPT zipped one by hand, with no library in it and its content in a params key. An install that hangs until the command times out counts as one that failed, as ChatGPT's npx did. Closes #194.
Contributor
There was a problem hiding this comment.
No issues found across 2 files
Tip: cubic could auto-approve low-risk PRs like this, if it thinks it's safe to merge. Learn more
View guided diff | Turn on auto-fix | Re-trigger cubic
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #194.
Three changes to the h5p-author skill's text (
skills/h5p-author/SKILL.md), each from what ChatGPT did with it, and their record indesign/author.md. No code changes, and the build is unchanged.What changes
<name>.source.jsonbeside the link. The page opens that file, and a link copied wrong into the reply builds nothing. Step 5's opening says the same..h5p. The skill's opening says never to put one together fromh5p.jsonandcontent.json, since one made by hand carries no libraries and nothing checks it.design/author.md:.h5p.SKILL.mdgrows from 14,670 to 15,154 characters, under the 20,000 that Open WebUI reads at once.Tested
All lab runs used Haiku, the weakest model first. There were 22 runs, each making the same three-question Question Set, with an author and licence given.
npxcommand for the usernpxcommand for the user.h5pmade by hand.h5p(one run each way).npxtimed out.npxanyway, against 0 of 6 old-text runs. This computer's npm answered, so they built. With npm cut off, every run handed over as the table shows.pnpm --filter @missing-elements/h5p-author run test:unit(183 tests) andtypecheckpass, andsync:skillchanges nothing.Not covered
npxcommand for themselves, under the old text and the new (one run in three each). The skill says never to end with commands for the user, and that does not reach this case.Release
This is a patch, h5p-author 0.9.7, skill text only. After it come the org site's pin bump, which also refreshes both zips,
npx skills update -g, and a new Claude app zip.Summary by cubic
Tightens the
h5p-authorskill's hand-over rules after ChatGPT failed them in tests; this is skill text and its design record only, no code changes (closes #194).<name>.source.jsonfile beside the link; ChatGPT wrote 2 of 3 links wrong by hand while its source file built every time..h5p; ChatGPT had zipped one by hand with no libraries and its content wrapped in aparamskey.npxtimed out.Written for commit eea37d7. Summary will update on new commits.