Repository navigation
Fix settings search highlighting every entry with the same title - #4273
Open
yuvarajvodiboina wants to merge 1 commit into
Open
yuvarajvodiboina wants to merge 1 commit into
yuvarajvodiboina wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4246
Settings search only passed the title of the opened result to the settings screen, so every heading and item with that title was highlighted, and the list scrolled to the first one. For example, opening the "Library > Global update" result for "Categories" also highlighted the "Categories" heading at the top of Library and never scrolled down to the item.
Search results now carry a key with the title, whether the entry is a group heading, and which entry of that kind with that title it is. The settings screen highlights and scrolls to that entry only. The onboarding "Restore" shortcut had the same problem with the Backup heading and item, and now points to the item.
Tested on an emulator (API 36): opening the heading result highlights only the heading, and opening the Global update result scrolls to and highlights only that item.
PreferenceScreenTestcovers the keys and the lookup.Images
Searching "Categories" in settings. The highlight blinks, so these are taken mid-blink.