Repository navigation
Remove API Scan from Python API pipeline - #26308
Stella Huang (StellaHuang95) merged 1 commit into
Conversation
Route npm dependency restores through DevDiv_PublicPackages while retaining the governed 1ES publishing controls. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
🔒 Automated review in progress — Rich Chiodo (@rchiodo) is auto-reviewing this PR. |
|
Reviewed commit: Result: 🔴 Verification detailsVerification: Automated verification is best effort. The PR author remains responsible for testing. Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: C:\Users\rchiodo\AppData\Local\Programs\Podman\podman.EXE --connection pyrx-automation failed: stderr: Error: unable to start container "1d5ed24a06b96f85619476655a23e8ca0a9878660822710cd106492cc21e7db9": crun: open `memory.max` for writing: No such file or directory: OCI runtime attempted to invoke a command that was not found Test runs: none recorded. |
Rich Chiodo (rchiodo)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
8de146b
into
microsoft:main
Summary
runAPIScanparameter, validation job, API Scan stage/tasks, TSA upload, service-connection dependency, and conditional publish dependencyDevDiv_PublicPackagesCFS feed using the sharedcustomNPMRegistrysetup@typesregistry at runtime so scoped packages and nested installs cannot fall back toregistry.npmjs.orgBuildstage and the 1ES-injectedSDLSourcesstageSecurity rationale
API Scan checks shipped Windows binaries for undocumented HVP API calls.
@vscode/python-extension@1.0.6contains onlyout/main.js,out/main.d.ts,package.json, and documentation/license files; it ships no.exe,.dll, or native.nodebinary. The documented API/interoperability policy still applies to JavaScript; this change classifies the binary scanner as not applicable to the current artifact, not the policy itself. API Scan must be revisited if a future package adds native or executable Windows content.The governed 1ES Official Publish pipeline remains responsible for the applicable controls: production-readiness policy, CodeQL, secure source/binary supply-chain analysis, source/binary AntiMalware, explicit CredScan and PoliCheck, JavaScript/TypeScript ESLint, SPMI secret scanning, PSScriptAnalyzer, ARMory, Component Governance/Detection, SBoM generation and validation, TSA routing, publish authorization, release provenance/artifact validation, human
ManualValidation, ESRP npm publication, and GitHub release creation. The explicit CFS, TSA, SBoM/release-job, and approval configuration remains in this pipeline; 1ES is not treated as zero-configuration.Validation
previewRunwith a local YAML override andpublishPythonApi=falsecompiled successfully.VSEng-APIScanSCreference.Publishdepends onBuildand injectedSDLSources; its publication condition expands false for the validation.@typesCFS verification before installs.refs/pull/26308/mergewithpublishPythonApi=false. The macOS job succeeded: npm authentication completed, both root and nested lockfiles were rewritten, default and@typesresolution both verifiedDevDiv_PublicPackages, and the root plus nested package installs/build passed.SDLSourcesfailed before user steps in the injected 1ES PT pre-job while accessingGuardian1ESPTUpstreamOrgFeed; their CFS steps did not run.PackageandPublishwere skipped, so this is an infrastructure/fork-access validation limitation rather than a pipeline-step failure.npx prettier --check build/azure-pipelines/devdiv/python-extension-api.ymlgit diff --checkNo publishing parameter was enabled, the release stage did not run, and nothing was published.
Tracking: microsoft/pyrx#10073