Skip to content

Prevent failure with non-standard window.navigator object. (mathjax/MathJax#3616) - #1579

Merged
dpvc merged 1 commit into
developfrom
issue3616
Oct 21, 2026
Merged

dpvc merged 1 commit into
developfrom
issue3616

Conversation

@dpvc

@dpvc dpvc commented Oct 13, 2026

Copy link
Copy Markdown
Member

This PR prevents the creation of the context object from failing when window.navigator doesn't have userAgent or appVersion properties, as apparently occurs in React Native.

Resolves issue mathjax/MathJax#3616.

@codecov

codecov Bot commented Oct 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.13%. Comparing base (e521742) to head (0172cee).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1579   +/-   ##
========================================
  Coverage    87.13%   87.13%           
========================================
  Files          392      392           
  Lines        89279    89279           
  Branches      5079     5080    +1     
========================================
  Hits         77793    77793           
+ Misses       11486    11465   -21     
- Partials         0       21   +21     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zorkow zorkow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc changed the title Prevent failure with non-standart window.navigator object. (mathjax/MathJax#3616) Prevent failure with non-standard window.navigator object. (mathjax/MathJax#3616) Oct 21, 2026
@dpvc
dpvc merged commit 6dd3fed into develop Oct 21, 2026
3 checks passed
@dpvc
dpvc deleted the issue3616 branch October 21, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants