Skip to content

fix(neuphonic): surface SSE errors through the TTS stream - #2873

Open
Apeksha9389 wants to merge 1 commit into
livekit:mainfrom
Apeksha9389:fix/neuphonic-sse-errors
Open

Apeksha9389 wants to merge 1 commit into
livekit:mainfrom
Apeksha9389:fix/neuphonic-sse-errors

Conversation

@Apeksha9389

Copy link
Copy Markdown
Contributor

Description

Route Neuphonic SSE parsing and provider errors through the TTS stream's error event. An SSE response such as data: {"status_code":401,"errors":["invalid API key"]} currently throws directly from the HTTP data listener, outside the stream's task error handling.

Changes Made

  • Reject the pending request future on a response parsing error and destroy the request.
  • Close the attempt queue on failure and skip flushing it again when the response closes.
  • Add provider-rejection and malformed-JSON regressions, plus a patch changeset.

Pre-Review Checklist

  • Build passes: Core and Neuphonic plugin build checks run locally.
  • AI-generated code reviewed: Focused error handling and regression coverage reviewed; AI-assisted implementation.
  • Changes explained: Error propagation and validation described here.
  • Scope appropriate: Neuphonic HTTP synthesis error handling, tests and release metadata only.
  • Video demo: Not applicable to a provider error-path regression.

Testing

  • Both error regressions fail on current main and pass with the change.
  • Tests assert no exception escapes the HTTP listener, the TTS error event fires once, output consumption ends, and the request is destroyed.
  • Required workspace formatting and lint commands pass (existing lint warnings remain).
  • Changeset metadata is validated for @livekit/agents-plugin-neuphonic.

@Apeksha9389
Apeksha9389 requested a review from a team as a code owner October 27, 2026 10:15
@changeset-bot

changeset-bot Bot commented Oct 27, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f717b18

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 41 packages
Name Type
@livekit/agents-plugin-neuphonic Patch
@livekit/agents Patch
@livekit/agents-plugin-anam Patch
@livekit/agents-plugin-anthropic Patch
@livekit/agents-plugin-assemblyai Patch
@livekit/agents-plugin-azure Patch
@livekit/agents-plugin-baseten Patch
@livekit/agents-plugin-bey Patch
@livekit/agents-plugin-cartesia Patch
@livekit/agents-plugin-cerebras Patch
@livekit/agents-plugin-deepgram Patch
@livekit/agents-plugin-did Patch
@livekit/agents-plugin-elevenlabs Patch
@livekit/agents-plugin-fishaudio Patch
@livekit/agents-plugin-google Patch
@livekit/agents-plugin-hume Patch
@livekit/agents-plugin-inworld Patch
@livekit/agents-plugin-krisp Patch
@livekit/agents-plugin-lemonslice Patch
@livekit/agents-plugin-liveavatar Patch
@livekit/agents-plugin-livekit Patch
@livekit/agents-plugin-meta Patch
@livekit/agents-plugin-minimax Patch
@livekit/agents-plugin-mistral Patch
@livekit/agents-plugin-mistralai Patch
@livekit/agents-plugin-openai Patch
@livekit/agents-plugin-perplexity Patch
@livekit/agents-plugin-phonic Patch
@livekit/agents-plugin-protoface Patch
@livekit/agents-plugin-resemble Patch
@livekit/agents-plugin-rime Patch
@livekit/agents-plugin-runway Patch
@livekit/agents-plugin-sarvam Patch
@livekit/agents-plugin-silero Patch
@livekit/agents-plugin-soniox Patch
@livekit/agents-plugin-speechify Patch
@livekit/agents-plugin-synthesia Patch
@livekit/agents-plugin-tavus Patch
@livekit/agents-plugins-test Patch
@livekit/agents-plugin-trugen Patch
@livekit/agents-plugin-xai Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant