Repository navigation
Conversation
A failed resubmission leaves an inactive transfer in rx_xfers. Cancelling it cannot produce a callback, so usb_disconnect waits indefinitely. Route resubmission failures through the existing cleanup path. Assisted-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed RX resubmission leaves an inactive transfer in
rx_xfers. Cancelling it cannot produce a callback, sousb_disconnect()waits indefinitely. Check the return value inrx_callback()and use the existing cleanup path on failure.Captured on Linux with libusb 1.0.29: the daemon stopped answering
ListDevicesafter the first phone connection. Its stack was in the disconnect loop; all three retained RX transfers were inactive, with no TX transfers remaining. The original resubmission error was not captured, and the patch has not yet been tested on the device.Validation: full Linux build; source-extracted callback tests covering all transfer statuses and successful/failed resubmission; teardown regression reproducing the wait before the change and completing after it.