Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
thetaPC
changed the title
thetaPC
marked this pull request as ready for review
November 3, 2026 16:05
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue URL: N/A
What is the current behavior?
The color generators' text input accepts
rgb()andhsl()values, but none of the generators handle them:rgb(12,34,56)produces an-rgbvalue ofNaN,12,34, andhsl()produces negative channels#to any value without one, so they print#rgb(12,34,56)What is the new behavior?
rgb()andhsl()values parse correctly:rgb(12,34,56)produces12,34,560054e9gets a#added;rgb()andhsl()values are printed as enteredDoes this introduce a breaking change?
Other information
To test, paste
rgb(12,34,56)into a color field on each preview page and compare its output with production: