Repository navigation
feat: add Asset Service and replace asset id with asset code - #2258
Open
MihaiAndrei98 wants to merge 4 commits into
Open
MihaiAndrei98 wants to merge 4 commits into
MihaiAndrei98 wants to merge 4 commits into
Conversation
github-actions
Bot
added
package: wallet/frontend
Tymmmy
reviewed
Oct 12, 2026
Tymmmy
reviewed
Oct 12, 2026
Tymmmy
approved these changes
Oct 15, 2026
dragosp1011
reviewed
Oct 26, 2026
| export class AssetService implements IAssetService { | ||
| constructor(private rhyzaAdminClient: RhyzaAdminClient) {} | ||
|
|
||
| async getAssetByCode(assetCode: string, scale?: number): Promise<Asset> { |
Contributor
There was a problem hiding this comment.
as assets have only one scale, the scale search looks unnecessary
dragosp1011
reviewed
Oct 26, 2026
| ? (asset) => asset.code === assetCode && asset.scale === scale | ||
| : (asset) => asset.code === assetCode | ||
| ) | ||
| if (!asset) { |
Contributor
There was a problem hiding this comment.
leave a new line before the if block and before return
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Changes