Repository navigation
feat(audience): attach identityType to track()/page() events - #2940
Merged
Merged
Conversation
✅ Audience Bundle Size — @imtbl/audience
Budget: 24.00 KB gzipped (warn at 20.00 KB) |
|
View your CI Pipeline Execution ↗ for commit c51fb54
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
✅ Pixel Bundle Size — @imtbl/pixel
Budget: 10.00 KB gzipped (warn at 8.00 KB) |
…e() events userId already carries forward from the last identify() call onto subsequent track()/page() events; identityType did not. Mirrors Segment/PostHog, which persist the last identify()'d identity and reattach it to later events until the next identify() or a reset/consent downgrade.
nattb8
force-pushed
the
feat/audience-persist-identity
branch
from
August 4, 2026 00:06
1274129 to
c51fb54
Compare
nattb8
marked this pull request as ready for review
August 4, 2026 00:11
JCSanPedro
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
userId already carries forward from the last identify() call onto every subsequent track()/page() event; identityType did not. This persists identityType alongside userId on the SDK instance and attaches it to track()/page() the same way, clearing both on reset()/consent downgrade.
Test plan
jest(audience/sdk, audience/core) — 461 tests, 0 failedtsc --noEmit— no type errorsoxlint(audience package tree) — no new warnings/errors