Repository navigation
Conversation
1 of 3 tasks
Contributor
size-limit report 📦Compared: 94ccdd8 (PR test merge using danf/node-schedule-monitor-jobs at d21b712) Against: 9310b4d (danf/node-schedule-monitor-jobs) · base run #64276
|
Sends check-ins for every named CronJob of the cron package (4.3+) through the orchestrion channel injection, with the cron expression and time zone as monitor config when Sentry reads it the same way. Bumps the cron dev dependency of the node integration tests to 4.x. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
wedamija
force-pushed
the
danf/node-schedule-monitor-jobs
branch
from
October 20, 2026 00:51
b9c729a to
231f7bc
Compare
wedamija
force-pushed
the
danf/cron-monitor-jobs
branch
from
October 20, 2026 00:51
69c3bca to
487dc0c
Compare
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 2 not successful, 55 successful. See the run.
Successful checks
|
wedamija
marked this pull request as ready for review
October 22, 2026 00:27
wedamija
requested review from
JPeer264,
isaacs,
nicohrubec and
s1gr1d
and removed request for
a team
October 22, 2026 00:27
… into danf/cron-monitor-jobs
Co-Authored-By: Claude <noreply@anthropic.com>
… into danf/cron-monitor-jobs
# Conflicts: # packages/server-utils/test/orchestrion/moduleInjectedTransform.test.ts
# Conflicts: # packages/server-utils/src/utils/cronMonitoring.ts
cronJobIntegration kept sending the config from the CronJob constructor after job.setTime, so Sentry reverted the monitor and reported false misses. Update the job's config after setTime.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 86acf7f. Configure here.
… into wt-cron-review-cron
…-jobs # Conflicts: # packages/server-utils/src/utils/cronMonitoring.ts
wedamija
requested review from
logaretm and
msonnb
and removed request for
a team
October 29, 2026 20:57
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a series adding automatic Crons monitoring for the most-used job schedulers in each SDK. Check-ins for a monitor that doesn't exist yet are dropped, so today each monitor has to be created by hand with its schedule copied from the code. Sending the job's schedule as the monitor config lets Sentry create the monitor and keep it in sync.
Adds
cronJobIntegration, which sends check-ins for every namedCronJobof thecronpackage with its cron expression andtimeZoneas the monitor config. It replacesSentry.cron.instrumentCron. Adding the integration is the opt-in. Job names came incron4.3.0, so older versions aren't instrumented.Jobs with
utcOffset, and schedules Crons can't express, like every 10 seconds, aren't monitored. Jobs created byinstrumentCronare skipped.@nestjs/schedulebuilds its jobs onCronJob, so NestJS apps should usenestIntegration({ monitorCronJobs: true })(#25471) instead, or both send check-ins for the same job. The node integration tests move tocron4.4.Stacked on #25474.