Repository navigation
Conversation
iamrz1
reviewed
Oct 26, 2026
malept
requested changes
Oct 27, 2026
…com/getoutreach/devbase into fix/DT-5647-mise-env-lockfile-drift
|
Link to code coverage report (posted by coverbot 🤖) |
malept
requested changes
Oct 27, 2026
malept
left a comment
malept
left a comment
Member
There was a problem hiding this comment.
I don't think validating mise lockfiles via bats tests is the right way to do this long-term, but in the short term this is fine. There should be a follow up task to integrate this into the devbase CLI (i.e., devbase lint mise-lock) and be called from the lint stage. It should also check that each locked tool has its platform URLs and checksums (as appropriate), and that the lockfile has no stale entries.
I'm requesting changes because the awk script still needs to be migrated to jq syntax.
Parses inline-table and array tool entries, and accepts fuzzy and "latest" requests that the lockfile resolves to a full version. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
malept
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
devbase's env lockfiles only get regenerated when the repo is restencilled. In #1215 devenv was bumped to 1.68.0 in mise.e2e.toml but not in the lock, so v2.40.0 shipped mise.e2e.lock with 1.67.0. Since mise 2026.10.19 CI has to look up the missing version over the network during the token-less bootstrap install and that lookup 404s on the private repo. As a result shared/e2e fails on every repo pinned to v2.40.0. This test fails devbase CI whenever mise.devbase.lock or mise.e2e.lock is missing a version its toml requests, so a manual bump without a relock can't ship again.
Jira ID
DT-5647
Notes for your reviewers