Repository navigation
Add C++20 compile guard for bundled fmt - #3689
Closed
Tyagiquamar wants to merge 1 commit into
Closed
Tyagiquamar wants to merge 1 commit into
Tyagiquamar wants to merge 1 commit into
Conversation
Regression test for constexpr format parsing reported in gabime#3500 on older bundled fmt releases.
Owner
|
How does it fixes #3500 ? I don't get it |
Contributor
Author
|
You're right this PR doesn't directly fix #3500. Sorry for the misleading The reported error comes from an older bundled fmt v9, while current spdlog uses fmt v12. My change only adds a C++20 compile-time regression check to catch similar failures in future builds. I'll remove the |
Owner
|
Closing. Not very relevant to current fmt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Fixes #3500.