Repository navigation
fix: keep Failed canary revisions until the primary is ready - #2002
Open
sarankumar1325 wants to merge 1 commit into
Open
sarankumar1325 wants to merge 1 commit into
sarankumar1325 wants to merge 1 commit into
Conversation
SyncStatus for a Failed canary rewrote lastAppliedSpec before HasTargetChanged ran. A new revision that arrived while the primary was not ready was then treated as already applied, so analysis never started. Check for target and dependency changes first; only SyncStatus when nothing changed. Fixes fluxcd#1995 Signed-off-by: sarankumar1325 <120080287+sarankumar1325@users.noreply.github.com>
sarankumar1325
requested review from
aryan9600 and
stefanprodan
as code owners
November 9, 2026 17:30
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a canary is
Failed,shouldAdvanceused to callSyncStatusbeforeHasTargetChanged. That wrote the current template hash intostatus.lastAppliedSpec. If the primary was not ready on that tick,advanceCanaryreturned without starting analysis, and later ticks no longer saw a target change.Move the Failed-state
SyncStatusto after the change checks, so a new revision stays pending until the primary is ready and analysis can start.Verification
TestScheduler_DeploymentFailedKeepsNewRevisionUntilPrimaryReadygo test ./pkg/controller/ -run TestScheduler_DeploymentFailedKeepsNewRevisionUntilPrimaryReadyFixes #1995